[
https://issues.apache.org/jira/browse/CAMEL-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278627#comment-16278627
]
ASF GitHub Bot commented on CAMEL-12062:
----------------------------------------
IIlllII commented on a change in pull request #2130: CAMEL-12062: Propagate
encoding in charset property from jaxb component
URL: https://github.com/apache/camel/pull/2130#discussion_r154951751
##########
File path:
components/camel-jaxb/src/main/java/org/apache/camel/converter/jaxb/JaxbDataFormat.java
##########
@@ -136,6 +136,10 @@ public void marshal(Exchange exchange, Object graph,
OutputStream stream) throws
String charset = exchange.getProperty(Exchange.CHARSET_NAME,
String.class);
if (charset == null) {
charset = encoding;
+ //Propagate the encoding of the exchange
Review comment:
@oscerd
Ok, what is the appropriate way to communicate the encoding?
I based this on what is done by the file endpoint, and AFAIK how that is
able to accomplish the same feature:
```
/**
* Set up the exchange properties with the options of the file endpoint
*/
public void configureExchange(Exchange exchange) {
// Now we just set the charset property here
if (getCharset() != null) {
exchange.setProperty(Exchange.CHARSET_NAME, getCharset());
}
}```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Jaxb component does not communicate charset when explicitly set
> ---------------------------------------------------------------
>
> Key: CAMEL-12062
> URL: https://issues.apache.org/jira/browse/CAMEL-12062
> Project: Camel
> Issue Type: Bug
> Components: camel-jaxb
> Affects Versions: 2.20.1
> Reporter: Jonas Waage
> Assignee: Andrea Cosentino
> Priority: Minor
>
> This test will cause a UnmappableCharacterException, since jaxb does not
> communicate the encoding of the bytes it outputs causing the file endpoint to
> assume it is UTF-8.
> This can be mitigated by adding an explicit reader in the route, but it would
> be nice if it worked OOTB.
> {code:java}
> /**
> * @version
> */
> public class ExplicitFileEncodingTest extends CamelTestSupport {
> @Override
> public void setUp() throws Exception {
> deleteDirectory("target/charset");
> super.setUp();
> }
> @Test
> public void testISOFileEncoding() throws Exception {
> PurchaseOrder order = new PurchaseOrder();
> //Data containing characters ÆØÅæøå that differ in utf-8 and iso
> String name = "\u00c6\u00d8\u00C5\u00e6\u00f8\u00e5";
> order.setName(name);
> order.setAmount(123.45);
> order.setPrice(2.22);
> MockEndpoint result = getMockEndpoint("mock:file");
> result.expectedFileExists("target/charset/output.txt");
> template.sendBody("direct:start", order);
> assertMockEndpointsSatisfied();
> JAXBContext jaxbContext =
> JAXBContext.newInstance("org.apache.camel.example");
> Unmarshaller unmarshaller = jaxbContext.createUnmarshaller();
> PurchaseOrder obj = (PurchaseOrder)unmarshaller.unmarshal(new
> File("target/charset/output.txt"));
> assertEquals(obj.getName(), name);
> }
> @Override
> protected RouteBuilder createRouteBuilder() throws Exception {
> return new RouteBuilder() {
> @Override
> public void configure() throws Exception {
> JaxbDataFormat jaxb = new
> JaxbDataFormat("org.apache.camel.example");
> jaxb.setEncoding("iso-8859-1");
> from("direct:start")
> .marshal(jaxb)
>
> .to("file:target/charset/?fileName=output.txt&charset=iso-8859-1");
> }
> };
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
