[ 
https://issues.apache.org/jira/browse/CAMEL-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281880#comment-16281880
 ] 

ASF GitHub Bot commented on CAMEL-12071:
----------------------------------------

GitHub user PyvesB opened a pull request:

    https://github.com/apache/camel/pull/2140

    Camel 12071 aws-sqs queue creation does not support FIFO queues

    We have addressed the issues described in [Camel 
12071](https://issues.apache.org/jira/browse/CAMEL-12071).
    
    Thanks to @slukes for pairing with me on this piece of work. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bbc/camel CAMEL-12071

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2140
    
----
commit 27ee0225b8914f26c73a76b5ea45b2526bd8d4da
Author: PyvesB <[email protected]>
Date:   2017-12-07T11:41:54Z

    CAMEL-12071 aws-sqs queue creation does not support FIFO queues

commit 3f8b9f87be82928af940831eb049f17d6ae4e9fd
Author: PyvesB <[email protected]>
Date:   2017-12-07T11:56:57Z

    CAMEL-12071 improved unit tests for createQueue

commit e96115a7239594b93038437f2a42631b25e038e0
Author: PyvesB <[email protected]>
Date:   2017-12-07T13:59:48Z

    CAMEL-12071 made unit tests fail in expected way

----


> aws-sqs queue creation does not support FIFO queues
> ---------------------------------------------------
>
>                 Key: CAMEL-12071
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12071
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-aws
>    Affects Versions: 2.21.0
>            Reporter: Pierre-Yves Bigourdan
>
> CAMEL-11224 added support for new FIFO queues. 
> Nevertheless the _createQueue_ method of the _SqsEndpoint_ class doesn't seem 
> to support the creation of FIFO queues. The [AWS 
> documentation|http://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_CreateQueue.html]
>  regarding the CreateQueue API states that the following attributes should be 
> set:
> - FifoQueue (needed otherwise AWS will fail the queue name validation, "Can 
> only include alphanumeric characters, hyphens, or underscores. 1 to 80 in 
> length")
> - ContentBasedDeduplication (defaults to false if omitted)
> We intend to submit a pull request to fix this with [~slukes].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to