[ 
https://issues.apache.org/jira/browse/CAMEL-12102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303378#comment-16303378
 ] 

Kamil commented on CAMEL-12102:
-------------------------------

I know that command is provided by the header, but it's not in the example. 
Don't you think, that this:
{code}
from("direct:start")
    .header(NetWeaverConstants.COMMAND, command)
    .toF("sap-netweaver:%s?username=%s&password=%s", url, username, password)
    .to("log:response")
    .to("velocity:flight-info.vm")
{code}
is slightly more readable?
Of course anybody can check the test cases, but there will be no need if 
documentation is more clear.

> Improve camel-sap-netweaver documentation
> -----------------------------------------
>
>                 Key: CAMEL-12102
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12102
>             Project: Camel
>          Issue Type: Improvement
>            Reporter: Kamil
>            Assignee: Claus Ibsen
>
> [Documentation|http://camel.apache.org/sap-netweaver.html] defines:
> {code}
> private String command = 
> "FlightCollection(AirLineID='AA',FlightConnectionID='0017',FlightDate=datetime'2012-08-29T00%3A00%3A00')";
> {code}
> which is never used in
> {code}
> from("direct:start")
>     .toF("sap-netweaver:%s?username=%s&password=%s", url, username, password)
>     .to("log:response")
>     .to("velocity:flight-info.vm")
> {code}
> so please provide valid example of how to use commands.
> By the way - it would be great if you could correct the format of:
> {code}
> lightCollection(AirLineID='AA',FlightConnectionID='0017',FlightDate=datetime'2012-08-29T00%3A00%3A00')
> {code}
> because it is not readable



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to