Chris Snyder created CAMEL-12109:
------------------------------------

             Summary: camel-zipkin - Generate tracing identifiers on exchange 
begin if they do not exist
                 Key: CAMEL-12109
                 URL: https://issues.apache.org/jira/browse/CAMEL-12109
             Project: Camel
          Issue Type: New Feature
          Components: camel-zipkin
            Reporter: Chris Snyder
            Priority: Minor


The current Zipkin instrumentation generates tracing IDs during client requests 
(in com.github.kristofa.brave.ClientTracer.startNewSpan()). However, it does 
not do so for server requests (see 
[ZipkinTracer.ZipkinRoutePolicy.onExchangeBegin()|https://github.com/apache/camel/blob/c6c02ff92a536e78f7ed1b9dd550d6531e852cee/components/camel-zipkin/src/main/java/org/apache/camel/zipkin/ZipkinTracer.java#L753]).
 This means that if the client does not supply its own tracing headers, nothing 
will be traced until a client request is made from within Camel.

This can be demonstrated using the camel-example-zipkin modules by removing the 
Zipkin instrumentation from the client module. When this is done, the service1 
module will not report any spans.

The [Zipkin documentation|https://zipkin.io/pages/instrumenting.html] indicates 
that tracing information should be generated when none is present: "When an 
incoming request has no trace information attached, we generate a random trace 
ID and span ID."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to