[
https://issues.apache.org/jira/browse/CAMEL-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322482#comment-16322482
]
ASF GitHub Bot commented on CAMEL-8799:
---------------------------------------
yihtserns commented on a change in pull request #528: CAMEL-8799: Make
json-path suppress PathNotFoundExceptions by default
URL: https://github.com/apache/camel/pull/528#discussion_r160999558
##########
File path:
components/camel-jsonpath/src/main/java/org/apache/camel/jsonpath/JsonPathEngine.java
##########
@@ -38,7 +41,8 @@
private final Configuration configuration;
public JsonPathEngine(String expression) {
- this.configuration = Configuration.defaultConfiguration();
+ Defaults defaults = DefaultsImpl.INSTANCE;
Review comment:
I wanted to create a PR, but I'm not very sure of the process.
I read that I have to:
1. Create a JIRA ticket
2. Commit and reference that ticket ID in the message
3. Create a PR
Are the steps correct? And if it is, will that be too much for some
refactoring to remove some duplicated lines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make it possible for JsonPath to suppress PathNotFoundException
> ---------------------------------------------------------------
>
> Key: CAMEL-8799
> URL: https://issues.apache.org/jira/browse/CAMEL-8799
> Project: Camel
> Issue Type: Improvement
> Components: camel-jsonpath
> Affects Versions: 2.15.2
> Reporter: Preben Asmussen
> Assignee: Claus Ibsen
> Fix For: 2.16.0
>
>
> It should be possible to suppress exceptions when evaluating JsonPath's.
> See
> http://camel.465427.n5.nabble.com/How-to-suppress-exceptions-from-Jsonpath-expressions-td5767384.html
> There are 2 options
> 1. Make it the default behaviour, so a null value will be returned instead
> of throwing an PathNotFoundException when evaluating json path expressions
> and the path is not found. I have a working patch for that here
> https://github.com/pax95/camel/commit/e09bd00d9199c88787f0acb0d2ea8c86e6a1bba9
> that I can do a PR on.
> 2. Make it configurable on the JsonPath component so you can enable/disable
> it on demand. This would also make it possible to expose other options from
> com.jayway.jsonpath.Option if they make sense. More work is require to make
> it available as both xml and java dsl.
> Currently I'm at bit overloaded to do a PR on 2 if that is the preferred
> option, so if any want to take over It will be fine.
> If option 1 is ok I'll create a PR.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
