ASF GitHub Bot commented on CAMEL-12221:

davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r165614505

 File path: 
 @@ -0,0 +1,55 @@
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.fhir;
+import ca.uhn.fhir.context.FhirContext;
+import ca.uhn.fhir.rest.api.MethodOutcome;
+import org.apache.camel.Converter;
+import org.apache.camel.Exchange;
+import org.hl7.fhir.instance.model.api.IBaseResource;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+public final class FhirTypeConverter {
+    private static final Logger LOGGER = 
+    private FhirTypeConverter() {
+        // Helper class
+    }
+    @Converter
+    public static String resourceToString(IBaseResource iBaseResource, 
Exchange exchange) {
 Review comment:
   Hmm maybe such a type converter is not so idea when you require those stuff 
to be on the exchange property. Sometimes a type converter is not the best 
thing to add, they should really ideally just be for basic type conversions. 
Consider removing this if possible.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Let's create a camel-fhir component
> -----------------------------------
>                 Key: CAMEL-12221
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12221
>             Project: Camel
>          Issue Type: New Feature
>            Reporter: John Poth
>            Priority: Major
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 

This message was sent by Atlassian JIRA

Reply via email to