[ https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350383#comment-16350383 ]
ASF GitHub Bot commented on CAMEL-12221: ---------------------------------------- johnpoth commented on a change in pull request #2206: [CAMEL-12221] Let's create a camel-fhir component URL: https://github.com/apache/camel/pull/2206#discussion_r165656082 ########## File path: components/camel-fhir/src/main/java/org/apache/camel/component/fhir/FhirEndpoint.java ########## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.fhir; + +import org.apache.camel.Consumer; +import org.apache.camel.Processor; +import org.apache.camel.Producer; +import org.apache.camel.impl.DefaultEndpoint; +import org.apache.camel.spi.UriEndpoint; + +/** + * Represents a fhir endpoint. + */ +@UriEndpoint(scheme = "fhir", title = "FHIR", syntax = "fhir://", label = "fhir", producerOnly = true) Review comment: The FHIR endpoint doesn't have any path or options. It will only execute the provided [IClientExecutable](https://github.com/jamesagnew/hapi-fhir/blob/0352d487204bf2f5eb0f87e204e77e225d47420b/hapi-fhir-base/src/main/java/ca/uhn/fhir/rest/gclient/IClientExecutable.java#L64) contained in the message body and do some error handling. @davsclaus The reasoning is that HAPI-FHIR comes with a nice [RestfulClient](https://github.com/jamesagnew/hapi-fhir/blob/0352d487204bf2f5eb0f87e204e77e225d47420b/hapi-fhir-base/src/main/java/ca/uhn/fhir/rest/client/api/IRestfulClient.java#L31) that is instantiated with the server URL and is able to construct every request depending on what FHIR version the server is running. I don't see anything else to add for the moment. If this feels weird I can remove the Endpoint and have the user execute the request in a processing step. Let me know what you think ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Let's create a camel-fhir component > ----------------------------------- > > Key: CAMEL-12221 > URL: https://issues.apache.org/jira/browse/CAMEL-12221 > Project: Camel > Issue Type: New Feature > Reporter: John Poth > Priority: Major > > Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io] > I can take care of the PR. -- This message was sent by Atlassian JIRA (v7.6.3#76005)