ASF GitHub Bot commented on CAMEL-12221:

davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166283634

 File path: 
 @@ -0,0 +1,57 @@
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.model.dataformat;
+import javax.xml.bind.annotation.XmlAccessType;
+import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlRootElement;
+import javax.xml.bind.annotation.XmlTransient;
+import org.apache.camel.CamelContext;
+import org.apache.camel.model.DataFormatDefinition;
+import org.apache.camel.spi.DataFormat;
+import org.apache.camel.spi.Metadata;
+ * The FHIR JSON data format is used to marshall/unmarshall to/from FHIR 
objects to/from JSON.
+ */
+@Metadata(firstVersion = "2.21.0", label = "dataformat,transformation,json", 
title = "FHIR JSON")
+@XmlRootElement(name = "fhir-json")
 Review comment:
   We dont use dash in those xml names, and btw it should be the same as you 
define in DataFormatsDefinition, so it should be `fhirJson` etc and ditto for 
the XML guy

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Let's create a camel-fhir component
> -----------------------------------
>                 Key: CAMEL-12221
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12221
>             Project: Camel
>          Issue Type: New Feature
>            Reporter: John Poth
>            Priority: Major
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 

This message was sent by Atlassian JIRA

Reply via email to