Daniel Fullarton created CAMEL-12271:
----------------------------------------

             Summary: SharedInternalProcessor attempts to call ResultProcessor 
after camel upgrade
                 Key: CAMEL-12271
                 URL: https://issues.apache.org/jira/browse/CAMEL-12271
             Project: Camel
          Issue Type: Bug
          Components: camel-core
    Affects Versions: 2.20.1, 2.20.0, 2.20.3
            Reporter: Daniel Fullarton


After upgrading fromĀ 2.19.4 we are experiencing backwards compatibility issues 
due to the introduction of the SharedInternalProcessor

A test of handling an empty 200 response body from a camel-http route now 
produces the following error :
{noformat}
org.apache.camel.InvalidPayloadException: No body available of type: #RESPONSE 
CLASS# but has value: 
org.apache.camel.converter.stream.InputStreamCache@7cbb65f9 of type: 
org.apache.camel.converter.stream.InputStreamCache on: Message[XXXX]. Caused 
by: No type converter available to convert from type: 
org.apache.camel.converter.stream.InputStreamCache to the required type: 
##RESPONSE CLASS## with value 
org.apache.camel.converter.stream.InputStreamCache@7cbb65f9. Exchange[####]. 
Caused by: [org.apache.camel.NoTypeConversionAvailableException - No type 
converter available to convert from type: 
org.apache.camel.converter.stream.InputStreamCache to the required type: 
##RESPONSE CLASS## with value 
org.apache.camel.converter.stream.InputStreamCache@7cbb65f9]
14:55:07 [tests]             at 
org.apache.camel.impl.MessageSupport.getMandatoryBody(MessageSupport.java:117)
14:55:07 [tests]             at 
org.apache.camel.processor.ConvertBodyProcessor.process(ConvertBodyProcessor.java:98)
14:55:07 [tests]             at 
org.apache.camel.util.AsyncProcessorHelper.process(AsyncProcessorHelper.java:109)
14:55:07 [tests]             at 
org.apache.camel.processor.ConvertBodyProcessor.process(ConvertBodyProcessor.java:69)
14:55:07 [tests]             at 
org.apache.camel.processor.SharedCamelInternalProcessor$InternalCallback.done(SharedCamelInternalProcessor.java:229)
14:55:07 [tests]             at 
org.apache.camel.processor.CamelInternalProcessor$InternalCallback.done(CamelInternalProcessor.java:262)
14:55:07 [tests]             at 
org.apache.camel.processor.Pipeline.process(Pipeline.java:127)
14:55:07 [tests]             at 
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:201)
14:55:07 [tests]             at 
org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
14:55:07 [tests]             at 
org.apache.camel.processor.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:186)
14:55:07 [tests]             at 
org.apache.camel.processor.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:86)
14:55:07 [tests]             at 
org.apache.camel.impl.ProducerCache$1.doInProducer(ProducerCache.java:541)
14:55:07 [tests]             at 
org.apache.camel.impl.ProducerCache$1.doInProducer(ProducerCache.java:506)
14:55:07 [tests]             at 
org.apache.camel.impl.ProducerCache.doInProducer(ProducerCache.java:369)
14:55:07 [tests]             at 
org.apache.camel.impl.ProducerCache.sendExchange(ProducerCache.java:506)
14:55:07 [tests]             at 
org.apache.camel.impl.ProducerCache.send(ProducerCache.java:264)
14:55:07 [tests]             at 
org.apache.camel.impl.DefaultProducerTemplate.requestBodyAndHeaders(DefaultProducerTemplate.java:355)
14:55:07 [tests]             ... 10 more
{noformat}
Digging into the code I can see that:

[https://github.com/apache/camel/commit/30917aba7d23be2a408660f3e4dd503a9cad5015#diff-ada5b0d990676bbc7d99201682c3065dR223]

Now calls the resultProcessor in the internal callback, previously it seems to 
have only done this when the underlying pipeline was successful?

I will try to find a way to replicate this outside of our environment but this 
appears to be a behavioural change in the way errors are handled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to