[
https://issues.apache.org/jira/browse/CAMEL-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394713#comment-16394713
]
ASF GitHub Bot commented on CAMEL-12343:
----------------------------------------
GitHub user fhassak opened a pull request:
https://github.com/apache/camel/pull/2252
CAMEL-12343 : refer to new contructor with defaultCamelContext for
deprecated constructor
Migrate from 2.19.2 to 2.20.2 failed.
```
java.lang.IllegalArgumentException: CamelContext must be specified on:
Message[]
at org.apache.camel.util.ObjectHelper.notNull(ObjectHelper.java:342)
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhassak/camel CAMEL-12343
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2252
----
commit fbace94ef92f41200f122884fa8ce6d32660b52c
Author: Farès Hassak <fares.hassak@...>
Date: 2018-03-12T00:21:34Z
CAMEL-12343 : refer to new contructor with defaultCamelContext for
deprecated constructor
----
> Using DefautMessage() and GenericFileMessage() without CamelContext throw
> Exception
> -----------------------------------------------------------------------------------
>
> Key: CAMEL-12343
> URL: https://issues.apache.org/jira/browse/CAMEL-12343
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.20.0, 2.20.1, 2.20.2, 2.21.0
> Reporter: Farès Hassak
> Priority: Major
>
> Hello,
> I am using version 2.19.2 and try to migrate to version 2.20.2 (and then to
> 2.21.0).
> Using DefautMessage() and GenericFileMessage() without CamelContext throw
> Exception :
> {code:java}
> java.lang.IllegalArgumentException: CamelContext must be specified on:
> Message[] at org.apache.camel.util.ObjectHelper.notNull(ObjectHelper.java:342)
> {code}
> In version 2.20.0, I see that these constructor was deprecated and new
> contructors was introduced for this new feature
> https://issues.apache.org/jira/browse/CAMEL-11149 :
> To remain better backward compatibility, i would suggest to refer the new
> constructor in deprecated contructor :
> {code:java}
> @Deprecated
> public DefaultMessage() {
> this(new DefaultCamelContext()); //use new contructor with
> DefaultCamelContext to avoid exception
> }
> public DefaultMessage(CamelContext camelContext) {
> setCamelContext(camelContext);
> }
> {code}
> {code:java}
> @Deprecated
> public GenericFileMessage() {
> this(new DefaultCamelContext()); //use new contructor with
> DefaultCamelContext to avoid exception
> }
> public GenericFileMessage(CamelContext camelContext) {
> super(camelContext);
> }
> /**
> * @deprecated use {@link #GenericFileMessage(CamelContext, GenericFile)}
> */
> @Deprecated
> public GenericFileMessage(GenericFile<T> file) {
> this(new DefaultCamelContext(), file); //use new contructor with
> DefaultCamelContext to avoid exception
> }
> public GenericFileMessage(CamelContext camelContext, GenericFile<T> file)
> {
> super(camelContext);
> this.file = file;
> }
> {code}
> Otherwise, the deprecated constructeur must be deleted in order to detect
> errors at compile time and not at runtime.
> Farès
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
