[
https://issues.apache.org/jira/browse/CAMEL-12352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400311#comment-16400311
]
ASF GitHub Bot commented on CAMEL-12352:
----------------------------------------
davsclaus commented on a change in pull request #2255: CAMEL-12352 - make
system property uppercase if given lowercase in si…
URL: https://github.com/apache/camel/pull/2255#discussion_r174763269
##########
File path:
camel-core/src/main/java/org/apache/camel/builder/ExpressionBuilder.java
##########
@@ -775,7 +776,7 @@ public Object evaluate(Exchange exchange) {
@Override
public String toString() {
- return "systemEnvironment(" + propertyName + ")";
+ return "systemEnvironment(" +
propertyName.toUpperCase(Locale.ROOT) + ")";
Review comment:
That is not needed here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> simple - Lookup env var should be case-insensitive
> --------------------------------------------------
>
> Key: CAMEL-12352
> URL: https://issues.apache.org/jira/browse/CAMEL-12352
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Major
> Fix For: 2.22.0
>
>
> We should upper-case env var text before looking it up in System.getenv as
> ENV vars are upper-case.
> Today you have to do
> .setBody().simple("${sysenv.FALLBACK}")
> But you may type
> .setBody().simple("${sysenv.fallback}")
> To lookup an ENV with key FALLBACK
>
> This can be implemented in the
> org.apache.camel.builder.ExpressionBuilder#systemEnvironmentExpression(java.lang.String,
> java.lang.String)
> Contributions is welcome
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
