[
https://issues.apache.org/jira/browse/CAMEL-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402320#comment-16402320
]
ASF GitHub Bot commented on CAMEL-12358:
----------------------------------------
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/camel/pull/2258
CAMEL-12358: Camel-SMPP: Use timeout when creating socket connection
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/camel
camel_12358_smpp_socket_connect_timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2258.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2258
----
commit f5e8cf84e827f3920074e93e53420e91f76c9122
Author: Pascal Schumacher <pascalschumacher@...>
Date: 2018-03-16T18:24:32Z
CAMEL-12358: Camel-SMPP: Use timeout when creating socket connection
----
> Camel-SMPP: Use timeout when creating socket connection
> -------------------------------------------------------
>
> Key: CAMEL-12358
> URL: https://issues.apache.org/jira/browse/CAMEL-12358
> Project: Camel
> Issue Type: Improvement
> Components: camel-smpp
> Reporter: Pascal Schumacher
> Assignee: Pascal Schumacher
> Priority: Major
>
> Camel-SMPP is using
> _javax.net.SocketFactory#createSocket(String host, int port)_ which "creates
> a socket and connects it to the specified port number at the specified
> address" according to the javadoc.
> As _SocketFactory_ is an abstract class, the behavior of _createSocket(String
> host, int port)_depends on the concrete implementation in use, but at least
> the default implementation of Oracle Java 8 Update 152 connects without using
> a timeout.
> As blocking operations without timeouts should be avoided Camel-SMPP should
> use a timeout when connecting the socket.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
