[ 
https://issues.apache.org/jira/browse/CAMEL-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407708#comment-16407708
 ] 

ASF GitHub Bot commented on CAMEL-12334:
----------------------------------------

zregvart commented on issue #2254: CAMEL-12334: Mapped date to LocalDate and 
time to LocalTime
URL: https://github.com/apache/camel/pull/2254#issuecomment-374887078
 
 
   Thank you for your effort @hemangajmera :1st_place_medal:. I don't think we 
should change the defaults but we should make date/date and time objects in 
DTOs configurable. Also the defaults as they were using ZonedDateTime are the 
safest way of handling date/time values. Relying just on offset could lead to 
wrong values with regards to daylight saving time.
   I see that we have a bit of work left to make this a bit better and I'm 
working in parallel on this. I think the best approach would be that I create a 
pull request with this work and invite you to review it. I'll incorporate bits 
that you have worked on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Salesforce DTO does not use correct datatype for "date" and "time" field
> ------------------------------------------------------------------------
>
>                 Key: CAMEL-12334
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12334
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-salesforce
>    Affects Versions: 2.20.2
>            Reporter: Hemang Ajmera
>            Assignee: Zoran Regvart
>            Priority: Major
>              Labels: maven
>             Fix For: 2.20.3, 2.21.1, 2.22.0
>
>
> The DTO classes generated by the Maven plugin uses ZonedDateTime for all three
>  * datetime
>  * date
>  * time
> The generation works fine, but is is not able to marshal/unmarshal correctly.
> The DTO should use different kind of field. My suggestion is to use
>  * ZonedDateTime for datetime
>  * LocalDate for date
>  * LocalTime for time
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to