[
https://issues.apache.org/jira/browse/CAMEL-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421967#comment-16421967
]
ASF GitHub Bot commented on CAMEL-10785:
----------------------------------------
onderson closed pull request #2273: CAMEL-10785 - add revapi integration
(considering current SNAPHOT and…
URL: https://github.com/apache/camel/pull/2273
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/camel-core/src/revapi/ignore.json
b/camel-core/src/revapi/ignore.json
new file mode 100644
index 00000000000..4d8e5fd2ae1
--- /dev/null
+++ b/camel-core/src/revapi/ignore.json
@@ -0,0 +1,24 @@
+{
+ "revapi" : {
+ "java": {
+ "missing-classes": {
+ "behavior": "ignore"
+ }
+ },
+ "ignore" : [
+ {
+ "code" : "java.class.nonPublicPartOfAPI"
+ },
+ {
+ "code" : "java.method.returnTypeChanged",
+ "package" : "org.apache.camel.management.mbean",
+ "classSimpleName" : "ManagedClaimCheck",
+ "methodName": "getDefinition",
+ "elementKind": "method",
+ "justification": "Needed for Claim-Check EIP",
+ "oldType": "org.apache.camel.model.ExpressionNode",
+ "newType": "org.apache.camel.model.ProcessorDefinition<?>"
+ }
+ ]
+ }
+}
\ No newline at end of file
diff --git a/parent/pom.xml b/parent/pom.xml
index a97c7d04587..e95bf1ffb6d 100644
--- a/parent/pom.xml
+++ b/parent/pom.xml
@@ -590,6 +590,8 @@
<restlet-version>2.3.12</restlet-version>
<restlet-woodstox-version>4.3.0</restlet-woodstox-version>
<restlet-yaml-version>1.13</restlet-yaml-version>
+ <revapi-java-version>0.15.1</revapi-java-version>
+ <revapi-maven-plugin-version>0.10.0</revapi-maven-plugin-version>
<rhino-bundle-version>1.7.7.1_1</rhino-bundle-version>
<rhino-version>1.7.7.1</rhino-version>
<rhino-js-version>1.7R2</rhino-js-version>
@@ -5434,6 +5436,36 @@
</plugins>
</build>
</profile>
+
+ <profile>
+ <id>revapi</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.revapi</groupId>
+ <artifactId>revapi-maven-plugin</artifactId>
+ <version>${revapi-maven-plugin-version}</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.revapi</groupId>
+ <artifactId>revapi-java</artifactId>
+ <version>${revapi-java-version}</version>
+ </dependency>
+ </dependencies>
+ <configuration>
+ <analysisConfigurationFiles>
+ <file>${project.basedir}/src/revapi/ignore.json</file>
+ </analysisConfigurationFiles>
+ </configuration>
+ <executions>
+ <execution>
+ <goals><goal>check</goal></goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
<profile>
<id>dependencycheck</id>
diff --git a/pom.xml b/pom.xml
index 55d3ac4a67c..4cdf4dad426 100644
--- a/pom.xml
+++ b/pom.xml
@@ -292,7 +292,8 @@
<exclude>**/file-sig-api.txt</exclude>
<exclude>**/Tasks__c.java</exclude>
<exclude>**/additional-spring-configuration-metadata.json</exclude>
- <exclude>**/*.proto</exclude>
+ <exclude>**/*.proto</exclude>
+ <exclude>**/src/revapi/ignore.json</exclude>
<!-- Maven Wrapper -->
<exclude>.mvn/**/*</exclude>
</excludes>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add revapi-maven-plugin for API modification reports
> -----------------------------------------------------
>
> Key: CAMEL-10785
> URL: https://issues.apache.org/jira/browse/CAMEL-10785
> Project: Camel
> Issue Type: New Feature
> Components: build system
> Reporter: Paolo Antinori
> Assignee: Önder Sezgin
> Priority: Major
> Fix For: 2.22.0
>
> Attachments: pom.xml
>
>
> http://revapi.org/modules/revapi-maven-plugin/
> Is a Maven plugin to help preventing breaking public APIs or to keep track of
> major change between version.
> This is the output of a sample run over {{camel-core/2.17.0}} vs.
> {{camel-core/2.18.0}}
> https://camel-revapi.netlify.com/revapi-report.html
> The plugin is quite powerful in its capabilities.
> This is the list of the event it can detect:
> http://revapi.org/modules/revapi-java/differences.html
> But it can obviously be pre-configured to disable not interesting finds or to
> completely whitelist some occurrences.
> See for example, how the guys of Drools configure their:
> https://github.com/etirelli/droolsjbpm-knowledge/blob/647deee821281a507035a96025ac44d626e535ab/kie-api/src/build/revapi-config.json
> The plugin can make the build job fail, in case it finds a breaking change
> (probably too strict requirement for Camel) or just produce it's report.
> I'm attaching my sample {{pom.xml}} if people want to have something to start
> playing with.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
