[
https://issues.apache.org/jira/browse/CAMEL-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475744#comment-16475744
]
ASF GitHub Bot commented on CAMEL-12511:
----------------------------------------
lburgazzoli closed pull request #2342: CAMEL-12511: Init
scheduledExecutorService before ConsulEventConsumer's watcher run
URL: https://github.com/apache/camel/pull/2342
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/components/camel-consul/src/main/java/org/apache/camel/component/consul/endpoint/ConsulEventConsumer.java
b/components/camel-consul/src/main/java/org/apache/camel/component/consul/endpoint/ConsulEventConsumer.java
index b74615b40fe..13753c23003 100644
---
a/components/camel-consul/src/main/java/org/apache/camel/component/consul/endpoint/ConsulEventConsumer.java
+++
b/components/camel-consul/src/main/java/org/apache/camel/component/consul/endpoint/ConsulEventConsumer.java
@@ -51,8 +51,8 @@ protected Runnable createWatcher(EventClient client) throws
Exception {
@Override
protected void doStart() throws Exception {
- super.doStart();
this.scheduledExecutorService =
this.executorServiceManager.newSingleThreadScheduledExecutor(this,
"ConsulEventConsumer");
+ super.doStart();
}
@Override
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> camel-consul - NPE on ConsulEventConsumer start
> -----------------------------------------------
>
> Key: CAMEL-12511
> URL: https://issues.apache.org/jira/browse/CAMEL-12511
> Project: Camel
> Issue Type: Bug
> Components: camel-consul
> Affects Versions: 2.21.1
> Reporter: Viachaslau Tsikhanovich
> Priority: Major
> Fix For: 2.21.2, 2.22.0
>
>
> When _doStart_ is called on ConsulEventConsumer it first
> [calls|https://github.com/apache/camel/blob/camel-2.21.1/components/camel-consul/src/main/java/org/apache/camel/component/consul/endpoint/ConsulEventConsumer.java#L54]
> _doStart_ of a superclass _AbstractConsulConsumer_ when
> _scheduledExecutorService_ is not initialized yet.
> EventWatcher run [is
> allowed|https://github.com/apache/camel/blob/camel-2.21.1/components/camel-consul/src/main/java/org/apache/camel/component/consul/endpoint/AbstractConsulConsumer.java#L95].
> Thus _EventWatcher.watch_ is called with uninitialized
> _scheduledExecutorService_ and failing with NPE.
> {quote}
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.camel.component.consul.endpoint.ConsulEventConsumer$EventWatcher.watch(ConsulEventConsumer.java:76)
> at
> org.apache.camel.component.consul.endpoint.ConsulEventConsumer$EventWatcher.watch(ConsulEventConsumer.java:68)
> at
> org.apache.camel.component.consul.endpoint.AbstractConsulConsumer$AbstractWatcher.run(AbstractConsulConsumer.java:96)
> at
> org.apache.camel.component.consul.endpoint.AbstractConsulConsumer.doStart(AbstractConsulConsumer.java:56)
> at
> org.apache.camel.component.consul.endpoint.ConsulEventConsumer.doStart(ConsulEventConsumer.java:54)
> at
> org.apache.camel.support.ServiceSupport.start(ServiceSupport.java:61)
> at
> org.apache.camel.impl.DefaultCamelContext.startService(DefaultCamelContext.java:3705)
> at
> org.apache.camel.impl.DefaultCamelContext.doStartOrResumeRouteConsumers(DefaultCamelContext.java:4023)
> at
> org.apache.camel.impl.DefaultCamelContext.doStartRouteConsumers(DefaultCamelContext.java:3958)
> at
> org.apache.camel.impl.DefaultCamelContext.safelyStartRouteServices(DefaultCamelContext.java:3878)
> at
> org.apache.camel.impl.DefaultCamelContext.doStartOrResumeRoutes(DefaultCamelContext.java:3642)
> at
> org.apache.camel.impl.DefaultCamelContext.doStartCamel(DefaultCamelContext.java:3494)
> at
> org.apache.camel.impl.DefaultCamelContext.access$000(DefaultCamelContext.java:209)
> at
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3253)
> at
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3249)
> at
> org.apache.camel.impl.DefaultCamelContext.doWithDefinedClassLoader(DefaultCamelContext.java:3272)
> at
> org.apache.camel.impl.DefaultCamelContext.doStart(DefaultCamelContext.java:3249)
> at
> org.apache.camel.support.ServiceSupport.start(ServiceSupport.java:61)
> at
> org.apache.camel.impl.DefaultCamelContext.start(DefaultCamelContext.java:3165)
> at
> org.apache.camel.spring.SpringCamelContext.start(SpringCamelContext.java:133)
> ...
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
