[
https://issues.apache.org/jira/browse/CAMEL-12542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503310#comment-16503310
]
ASF GitHub Bot commented on CAMEL-12542:
----------------------------------------
dmvolod commented on a change in pull request #2359: CAMEL-12542:seda - Have a
default queue size limit
URL: https://github.com/apache/camel/pull/2359#discussion_r193414672
##########
File path:
camel-core/src/main/java/org/apache/camel/component/seda/SedaComponent.java
##########
@@ -35,12 +36,12 @@
*/
public class SedaComponent extends UriEndpointComponent {
protected final Logger log = LoggerFactory.getLogger(getClass());
- protected final int maxConcurrentConsumers = 500;
+ protected final int maxConcurrentConsumers =
SedaConstants.MAX_CONCURRENT_CONSUMERS;
- @Metadata(label = "consumer", defaultValue = "1")
- protected int concurrentConsumers = 1;
- @Metadata(label = "advanced")
- protected int queueSize;
+ @Metadata(label = "consumer", defaultValue =
""+SedaConstants.CONCURRENT_CONSUMERS)
Review comment:
You must see errors like ''+' is not preceded with whitespace.' but build
doen't stop as expected.
Please run and check output again.
@oscerd do you have any ideas why maven-checkstyle-plugin:3.0.0:checkstyle
become skips build on audit errors?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> seda - Have a default queue size limit
> --------------------------------------
>
> Key: CAMEL-12542
> URL: https://issues.apache.org/jira/browse/CAMEL-12542
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Major
> Fix For: 3.0.0
>
>
> The seda/vm queues are unbounded by default. But some users may fill up
> endless messages into these queues and hit OOME.
> We should possible set a default queue size of some reasonable size so that
> out of the box this wont happen.
> Maybe 1000 messages is a good default. People should not really store a very
> high number of in-flight messages in a JVM / CamelContext. Its not good
> practice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
