[
https://issues.apache.org/jira/browse/CAMEL-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514817#comment-16514817
]
ASF GitHub Bot commented on CAMEL-6840:
---------------------------------------
aldettinger commented on a change in pull request #2376: CAMEL-6840 - add
grouped throttling feature, both XML and Java DSL should be fine now.
URL: https://github.com/apache/camel/pull/2376#discussion_r195905663
##########
File path: camel-core/src/main/java/org/apache/camel/processor/Throttler.java
##########
@@ -111,13 +128,21 @@ public boolean process(final Exchange exchange, final
AsyncCallback callback) {
throw new RejectedExecutionException("Run is not allowed");
}
- calculateAndSetMaxRequestsPerPeriod(exchange);
+ Integer key;
+ if (correlationExpression != null) {
+ key = correlationExpression.evaluate(exchange, Integer.class);
Review comment:
If we use `key` as a finer grain lock, I would make a defensive copy because
I'm not sure that the reference returned by evaluate could be used as a lock by
another thread for another purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Allow Throttler EIP to specify SLA per client/correlated-group
> --------------------------------------------------------------
>
> Key: CAMEL-6840
> URL: https://issues.apache.org/jira/browse/CAMEL-6840
> Project: Camel
> Issue Type: New Feature
> Components: camel-core, eip
> Reporter: Christian Posta
> Assignee: Önder Sezgin
> Priority: Major
> Fix For: 2.22.0
>
>
> Basic idea is to allow throttler to have a predicate to determine whether or
> not to apply throttling to that exchange.
> From this Mailing List discussion:
> http://camel.465427.n5.nabble.com/Throttling-by-client-ID-td5741032.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
