[
https://issues.apache.org/jira/browse/CAMEL-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523687#comment-16523687
]
ASF GitHub Bot commented on CAMEL-12588:
----------------------------------------
dmvolod commented on a change in pull request #2387: CAMEL-12588
AggregateProcessor does not stop AggregateTimeoutChecker
URL: https://github.com/apache/camel/pull/2387#discussion_r198132810
##########
File path:
camel-core/src/main/java/org/apache/camel/processor/aggregate/AggregateProcessor.java
##########
@@ -1448,6 +1448,12 @@ protected void doStop() throws Exception {
if (recoverService != null) {
camelContext.getExecutorServiceManager().shutdown(recoverService);
}
+
+ if (timeoutCheckerExecutorService != null) {
Review comment:
@gsudharsan , I'm not sure, that it's related to the CAMEL-4037. I think the
reason why the tests are fails, that shutdown of the executor
timeoutCheckerExecutorService is controlled by
shutdownTimeoutCheckerExecutorService boolean flag but not null value of the
instance itself.
@davsclaus , @oscerd what do you think about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call
> -----------------------------------------------------------------------------
>
> Key: CAMEL-12588
> URL: https://issues.apache.org/jira/browse/CAMEL-12588
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.21.1
> Reporter: Sudharsan Govindarajan
> Assignee: Andrea Cosentino
> Priority: Major
>
> When a Aggregator route is stopped, only the AggregateRecoveryChecker threads
> are stopped and not the AggregateTimeoutChecker threads. They keep lingering
> around.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
