[
https://issues.apache.org/jira/browse/CAMEL-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531081#comment-16531081
]
ASF GitHub Bot commented on CAMEL-12607:
----------------------------------------
dmvolod closed pull request #2402: CAMEL-12607: When using Tokenizer skipFirst
java.util.NoSuchElementException if only one element [will merge after 2.22.0
release]
URL: https://github.com/apache/camel/pull/2402
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/camel-core/src/main/java/org/apache/camel/util/GroupTokenIterator.java
b/camel-core/src/main/java/org/apache/camel/util/GroupTokenIterator.java
index 0bfd2689a4b..2f05116d8f0 100644
--- a/camel-core/src/main/java/org/apache/camel/util/GroupTokenIterator.java
+++ b/camel-core/src/main/java/org/apache/camel/util/GroupTokenIterator.java
@@ -50,7 +50,7 @@
private final ByteArrayOutputStream bos = new ByteArrayOutputStream();
/**
- * Creates a new token based group titerator
+ * Creates a new token based group iterator
*
* @param camelContext the camel context
* @param it the iterator to group
@@ -155,7 +155,12 @@ private Object doNext() throws IOException,
NoTypeConversionAvailableException {
data = it.next();
if (skipFirst && hasSkipFirst.compareAndSet(false, true)) {
- data = it.next();
+ if (it.hasNext()) {
+ data = it.next();
+ } else {
+ // Content with header only which is marked to skip
+ data = "";
+ }
}
// include token in between
diff --git
a/camel-core/src/test/java/org/apache/camel/processor/SplitGroupSkipFirstTest.java
b/camel-core/src/test/java/org/apache/camel/processor/SplitGroupSkipFirstTest.java
index d85cac27c21..5c09847c27e 100644
---
a/camel-core/src/test/java/org/apache/camel/processor/SplitGroupSkipFirstTest.java
+++
b/camel-core/src/test/java/org/apache/camel/processor/SplitGroupSkipFirstTest.java
@@ -31,6 +31,14 @@ public void testSplitSkipFirst() throws Exception {
assertMockEndpointsSatisfied();
}
+
+ public void testSplitSkipFirstOnlyHeader() throws Exception {
+ getMockEndpoint("mock:group").expectedBodiesReceived("");
+
+ template.sendBody("direct:start", "##comment\n");
+
+ assertMockEndpointsSatisfied();
+ }
@Override
protected RouteBuilder createRouteBuilder() throws Exception {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> When using Tokenizer skipFirst - java.util.NoSuchElementException if only one
> element
> -------------------------------------------------------------------------------------
>
> Key: CAMEL-12607
> URL: https://issues.apache.org/jira/browse/CAMEL-12607
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.21.1
> Reporter: Sergey Savenko
> Assignee: Dmitry Volodin
> Priority: Minor
>
> I use {{.split().tokenize("\n", 10000, true).streaming()}} to stream csv file
> with header row and skip first line.
> When file contains ONLY header row - {{java.util.NoSuchElementException}} is
> thrown in
> [https://github.com/apache/camel/blob/camel-2.21.1/camel-core/src/main/java/org/apache/camel/util/GroupTokenIterator.java#L158],
> because when it skips first line - it does not check if it has next line and
> just calls next().
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
