[
https://issues.apache.org/jira/browse/CAMEL-12554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536939#comment-16536939
]
ASF GitHub Bot commented on CAMEL-12554:
----------------------------------------
jborza opened a new pull request #2415: CAMEL-12554 - camel-geocoder - Use new
API
URL: https://github.com/apache/camel/pull/2415
Hi,
as described in
https://issues.apache.org/jira/browse/CAMEL-12554
Geocoding and reverse geo-ip is now using a single library: Google Maps API
Web Services
Not sure if we usually remove component options in Camel, but there have
been a few changes as follow:
- I had to remove the options httpClientConfigurer, httpConnectionManager as
the http connections are no longer managed by this library.
- I also removed proxyAuthDomain, proxyAuthHost and proxyAuthMethod=NTLM as
the new library doesn't support that either.
Also as the API requires an API key the tests attempt to retrieve it from
CAMEL_GEOCODER_APIKEY. Again, not sure what is the best practice - probably the
same thing we'd do in Azure/AWS integration which probably requires some kind
of API key to be included as well.
Other option may be using a mock Google Maps endpoint, which I'm a bit
reluctant to write as it may change any time.
Regards,
Juraj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> camel-geocoder - Use new API
> ----------------------------
>
> Key: CAMEL-12554
> URL: https://issues.apache.org/jira/browse/CAMEL-12554
> Project: Camel
> Issue Type: Improvement
> Components: camel-geocoder
> Reporter: Claus Ibsen
> Priority: Major
> Fix For: 2.23.0
>
>
> See
> [https://github.com/apilayer/freegeoip#readme]
> There is a newer API. Not sure if we have migrated already, but as the old
> API is terminated in July 2018 then we dont have so much time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
