[
https://issues.apache.org/jira/browse/CAMEL-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540648#comment-16540648
]
ASF GitHub Bot commented on CAMEL-12643:
----------------------------------------
GitHub user lzh3636 opened a pull request:
https://github.com/apache/camel/pull/2422
CAMEL-12643: Inadequate information for handling catch clauses
The description of the problem:
https://issues.apache.org/jira/browse/CAMEL-12643
I added a full stack trace information to the logging statement, so that
the exception type can be generated to the logs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lzh3636/camel CAMEL-12643
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2422.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2422
----
commit 91a59a8dfb81cf5726e12272a7afe6a5fe70078b
Author: zhenhaoli <lizi422@...>
Date: 2018-07-11T20:54:53Z
CAMEL-12643: Inadequate information for handling catch clauses
----
> Inadequate information for handling catch clauses
> -------------------------------------------------
>
> Key: CAMEL-12643
> URL: https://issues.apache.org/jira/browse/CAMEL-12643
> Project: Camel
> Issue Type: Improvement
> Reporter: Zhenhao Li
> Priority: Minor
>
> There are some situations that different exception types are caught, but the
> handling of those exceptions cannot show the differences between those types.
> Here are the code snippets which have this problem:
> org.apache.camel.component.rabbitmq.*RabbitConsumer*.handleShutdownSignal,
> *Line 271*
> catch (IOException | TimeoutException e)
> { log.warn("Unable to obtain a RabbitMQ channel. Will try again"); ...
> }
> It may cause confusions to the person who is reading the log, the person can
> not know what exception happened here and cannot distinguish if the exception
> type is IOException or TimeoutException. Simply adding a full stack trace is
> able to improve it.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
