[
https://issues.apache.org/jira/browse/CAMEL-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541865#comment-16541865
]
ASF GitHub Bot commented on CAMEL-12643:
----------------------------------------
davsclaus commented on issue #2422: CAMEL-12643: Inadequate information for
handling catch clauses
URL: https://github.com/apache/camel/pull/2422#issuecomment-404565082
The + on the string concat can likely be merged into the other, and also we
can log the stacktrace at DEBUG level, and say that in the WARN message - that
is something we do in other places sometimes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> camel-rabbitmq - Inadequate information for handling catch clauses
> ------------------------------------------------------------------
>
> Key: CAMEL-12643
> URL: https://issues.apache.org/jira/browse/CAMEL-12643
> Project: Camel
> Issue Type: Improvement
> Components: camel-rabbitmq
> Reporter: Zhenhao Li
> Priority: Minor
>
> There are some situations that different exception types are caught, but the
> handling of those exceptions cannot show the differences between those types.
> Here are the code snippets which have this problem:
> {code}
> org.apache.camel.component.rabbitmq.*RabbitConsumer*.handleShutdownSignal,
> *Line 271*
> catch (IOException | TimeoutException e)
> { log.warn("Unable to obtain a RabbitMQ channel. Will try again"); ...
> }
> {code}
> It may cause confusions to the person who is reading the log, the person can
> not know what exception happened here and cannot distinguish if the exception
> type is IOException or TimeoutException. Simply adding a full stack trace is
> able to improve it.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
