[
https://issues.apache.org/jira/browse/CAMEL-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543425#comment-16543425
]
Neil Drummond commented on CAMEL-12638:
---------------------------------------
[~mario.papandrea] I don't think that will fix the issue.
Consider the case of a service that injects {{FluentProducerTemplate}}:
{code:java}
@Service
public class MyService {
@Inject
private FluentProducerTemplate fluentProducerTemplate
public void useProducerTemplate() {
....
}
}{code}
In this case, if {{useProducerTemplate()}} is called from multiple threads, and
it uses the {{fluentProducerTemplate}}, then even if you give it prototype
scope, some instances may still be used in a multithreaded way, and may still
run into this issue. (It might make this happen less often, and fix it in some
cases, but not in all cases).
I think any proper solution that doesn't break the API of
{{FluentProducerTemplate}} will need {{DefaultFluentProducerTemplate}} to be a
proper thread-safe class, such that a single instance can be used in multiple
threads at the same time.
Right now, because {{DefaultFluentProducerTemplate}} implements
{{FluentProducerTemplate}}, it really ought to be thread-safe, as is guaranteed
in the javadocs of the {{FluentProducerTemplate}} interface.
> DefaultFluentProducerTemplate is not thread safe
> ------------------------------------------------
>
> Key: CAMEL-12638
> URL: https://issues.apache.org/jira/browse/CAMEL-12638
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.20.2
> Reporter: Lukasz
> Priority: Major
> Attachments: image-2018-07-12-17-58-09-225.png
>
>
> I think we have rediscovered the CAMEL-10820 bug. A body of one request gets
> replaced with a body of proceeding request, in our case we use *request()*
> method instead of *asyncSend()*.
> We use camel together with spring-boot. Consider following code:
>
> {code:java}
> @Service
> public class UseCamelService {
> private FluentProducerTemplate producer;
> @Autowired
> public UseCamelService(FluentProducerTemplate producer) {
> this.producer = producer;
> }
> public String getValueFromCamel(String body) {
> return producer.to("route").withBody(body).request(String.class);
> }
> }
> {code}
> If *UseCamelService.getValueFromCamel()* gets called from two different
> threads it is possible for the latter one to override the body of the first
> one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
