[
https://issues.apache.org/jira/browse/CAMEL-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577245#comment-16577245
]
ASF GitHub Bot commented on CAMEL-12726:
----------------------------------------
aldettinger closed pull request #2467: CAMEL-12726: Fix FindBugs warnings:
Invocation of toString on an array
URL: https://github.com/apache/camel/pull/2467
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedRemoveHeaders.java
b/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedRemoveHeaders.java
index 723e4d71703..ae5d333ebae 100644
---
a/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedRemoveHeaders.java
+++
b/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedRemoveHeaders.java
@@ -16,6 +16,8 @@
*/
package org.apache.camel.management.mbean;
+import java.util.Arrays;
+
import org.apache.camel.CamelContext;
import org.apache.camel.api.management.ManagedResource;
import org.apache.camel.api.management.mbean.ManagedRemoveHeadersMBean;
@@ -34,7 +36,7 @@ public ManagedRemoveHeaders(CamelContext context,
RemoveHeadersProcessor process
super(context, processor, definition);
this.processor = processor;
if (processor.getExcludePattern() != null) {
- exclude = processor.getExcludePattern().toString();
+ exclude = Arrays.toString(processor.getExcludePattern());
} else {
exclude = null;
}
diff --git
a/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedRemoveProperties.java
b/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedRemoveProperties.java
index f01a0a856a7..f843b77efba 100644
---
a/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedRemoveProperties.java
+++
b/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedRemoveProperties.java
@@ -16,6 +16,8 @@
*/
package org.apache.camel.management.mbean;
+import java.util.Arrays;
+
import org.apache.camel.CamelContext;
import org.apache.camel.api.management.ManagedResource;
import org.apache.camel.api.management.mbean.ManagedRemovePropertiesMBean;
@@ -34,7 +36,7 @@ public ManagedRemoveProperties(CamelContext context,
RemovePropertiesProcessor p
super(context, processor, definition);
this.processor = processor;
if (processor.getExcludePattern() != null) {
- exclude = processor.getExcludePattern().toString();
+ exclude = Arrays.toString(processor.getExcludePattern());
} else {
exclude = null;
}
diff --git
a/components/camel-box/camel-box-api/src/main/java/org/apache/camel/component/box/api/BoxFoldersManager.java
b/components/camel-box/camel-box-api/src/main/java/org/apache/camel/component/box/api/BoxFoldersManager.java
index 1fe7d99f993..eb2ed554505 100644
---
a/components/camel-box/camel-box-api/src/main/java/org/apache/camel/component/box/api/BoxFoldersManager.java
+++
b/components/camel-box/camel-box-api/src/main/java/org/apache/camel/component/box/api/BoxFoldersManager.java
@@ -201,7 +201,7 @@ public BoxFolder createFolder(String parentFolderId, String
folderName) {
*/
public BoxFolder createFolder(String parentFolderId, String... path) {
try {
- LOG.debug("Creating folder with path '" + path + "' in
parent_folder(id=" + parentFolderId + ")");
+ LOG.debug("Creating folder with path '" + Arrays.toString(path) +
"' in parent_folder(id=" + parentFolderId + ")");
if (parentFolderId == null) {
throw new IllegalArgumentException("Parameter 'parentFolderId'
can not be null");
}
diff --git
a/components/camel-jsch/src/main/java/org/apache/camel/component/scp/ScpOperations.java
b/components/camel-jsch/src/main/java/org/apache/camel/component/scp/ScpOperations.java
index d0efd1487eb..a9ea3008cb1 100644
---
a/components/camel-jsch/src/main/java/org/apache/camel/component/scp/ScpOperations.java
+++
b/components/camel-jsch/src/main/java/org/apache/camel/component/scp/ScpOperations.java
@@ -22,6 +22,7 @@
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
+import java.util.Arrays;
import java.util.Hashtable;
import java.util.List;
@@ -259,7 +260,7 @@ private Session createSession(ScpConfiguration config) {
try {
jsch.addIdentity("camel-jsch", data, null, pkfp != null ?
pkfp.getBytes() : null);
} catch (Exception e) {
- throw new GenericFileOperationFailedException("Cannot load
private key bytes: " + config.getPrivateKeyBytes(), e);
+ throw new GenericFileOperationFailedException("Cannot load
private key bytes: " + Arrays.toString(config.getPrivateKeyBytes()), e);
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> FindBugs warnings: Invocation of toString on an array
> -----------------------------------------------------
>
> Key: CAMEL-12726
> URL: https://issues.apache.org/jira/browse/CAMEL-12726
> Project: Camel
> Issue Type: Bug
> Components: camel-box, camel-core, camel-jsch
> Reporter: Hiroaki Yoshida
> Priority: Major
>
> FindBugs-3.0.1 ([http://findbugs.sourceforge.net/]) reported 4
> DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
> {code:java}
> H C USELESS_STRING: Invocation of toString on
> org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new
> org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext,
> RemoveHeadersProcessor, ProcessorDefinition) At
> ManagedRemoveHeaders.java:[line 37]
> H C USELESS_STRING: Invocation of toString on
> org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in
> new org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext,
> RemovePropertiesProcessor, ProcessorDefinition) At
> ManagedRemoveProperties.java:[line 37]
> M C USELESS_STRING: Invocation of toString on
> ScpConfiguration.getPrivateKeyBytes() in
> org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)
> At ScpOperations.java:[line 262]
> M C USELESS_STRING: Invocation of toString on path in
> org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String,
> String[]) At BoxFoldersManager.java:[line 204]
> {code}
> The description of the bug is as follows:
> {quote}*USELESS_STRING: Invocation of toString on an array
> (DMI_INVOKING_TOSTRING_ON_ARRAY)*
> The code invokes toString on an array, which will generate a fairly useless
> result such as [C@16f0472. Consider using Arrays.toString to convert the
> array into a readable String that gives the contents of the array. See
> Programming Puzzlers, chapter 3, puzzle 12.
>
> [http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY]
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
