[
https://issues.apache.org/jira/browse/CAMEL-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578373#comment-16578373
]
ASF GitHub Bot commented on CAMEL-12587:
----------------------------------------
davsclaus closed pull request #2470: CAMEL-12587: camel-zipkin-starter fails
mapping service names
URL: https://github.com/apache/camel/pull/2470
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/examples/camel-example-zipkin/service1/src/main/resources/application.properties
b/examples/camel-example-zipkin/service1/src/main/resources/application.properties
index e3f6ebe8af4..54deb42e114 100644
---
a/examples/camel-example-zipkin/service1/src/main/resources/application.properties
+++
b/examples/camel-example-zipkin/service1/src/main/resources/application.properties
@@ -23,8 +23,8 @@ camel.springboot.main-run-controller=true
camel.zipkin.endpoint=http://localhost:9411/api/v2/spans
# the zipkin service name
-camel.zipkin.server-service-mappings.*=service1
-camel.zipkin.client-service-mappings.*=service2
+camel.zipkin.server-service-mappings.[*]=service1
+camel.zipkin.client-service-mappings.[*]=service2
# include message bodies in the traces (not recommended for production)
camel.zipkin.include-message-body-streams=true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> camel-zipkin-starter fails mapping service names
> ------------------------------------------------
>
> Key: CAMEL-12587
> URL: https://issues.apache.org/jira/browse/CAMEL-12587
> Project: Camel
> Issue Type: Improvement
> Components: camel-zipkin
> Reporter: Adrian Cole
> Priority: Major
>
> camel-zipkin-starter uses mapped properties for service names. For example,
> the following wildcard properties are used in camel-example-zipkin
> camel.zipkin.server-service-mappings.*=service1
> camel.zipkin.client-service-mappings.*=service2
>
> trunk is currently broken, as running the service1 part of the example ends
> with errors like so unless you comment out the mappings:
>
> Caused by: org.springframework.core.convert.ConverterNotFoundException: No
> converter found capable of converting from type [java.lang.String] to type
> [java.util.Map<java.lang.String, java.lang.String>] at
> org.springframework.core.convert.support.GenericConversionService.handleConverterNotFound
> (GenericConversionService.java:321) at
> org.springframework.core.convert.support.GenericConversionService.convert
> (GenericConversionService.java:194) at
> org.springframework.boot.context.properties.bind.BindConverter$CompositeConversionService.convert
> (BindConverter.java:162) at
> org.springframework.boot.context.properties.bind.BindConverter.convert
> (BindConverter.java:96)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
