[
https://issues.apache.org/jira/browse/CAMEL-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593941#comment-16593941
]
ASF GitHub Bot commented on CAMEL-12109:
----------------------------------------
GitHub user ramu11 opened a pull request:
https://github.com/apache/camel/pull/2494
camel-zipkin - Generate tracing identifiers on exchange begin if they…
CAMEL-12109:camel-zipkin - Generate tracing identifiers on exchange begin
if they do not exist
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramu11/camel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2494.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2494
----
commit 3805a555f934b5abd421ccb358ece56e869f0aa6
Author: Ramu <kkakarla@...>
Date: 2018-08-27T16:52:36Z
camel-zipkin - Generate tracing identifiers on exchange begin if they do
not exist
----
> camel-zipkin - Generate tracing identifiers on exchange begin if they do not
> exist
> ----------------------------------------------------------------------------------
>
> Key: CAMEL-12109
> URL: https://issues.apache.org/jira/browse/CAMEL-12109
> Project: Camel
> Issue Type: New Feature
> Components: camel-zipkin
> Reporter: Chris Snyder
> Assignee: Ramu
> Priority: Minor
>
> The current Zipkin instrumentation generates tracing IDs during client
> requests (in com.github.kristofa.brave.ClientTracer.startNewSpan()). However,
> it does not do so for server requests (see
> [ZipkinTracer.ZipkinRoutePolicy.onExchangeBegin()|https://github.com/apache/camel/blob/c6c02ff92a536e78f7ed1b9dd550d6531e852cee/components/camel-zipkin/src/main/java/org/apache/camel/zipkin/ZipkinTracer.java#L753]).
> This means that if the client does not supply its own tracing headers,
> nothing will be traced until a client request is made from within Camel.
> This can be demonstrated using the camel-example-zipkin modules by removing
> the Zipkin instrumentation from the client module. When this is done, the
> service1 module will not report any spans.
> The [Zipkin documentation|https://zipkin.io/pages/instrumenting.html]
> indicates that tracing information should be generated when none is present:
> "When an incoming request has no trace information attached, we generate a
> random trace ID and span ID."
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
