[
https://issues.apache.org/jira/browse/CAMEL-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623908#comment-16623908
]
ASF GitHub Bot commented on CAMEL-12813:
----------------------------------------
aldettinger closed pull request #2527: CAMEL-12813: Added DEBUG logs in
camel-netty4 codecs when incoming co…
URL: https://github.com/apache/camel/pull/2527
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketByteArrayDecoder.java
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketByteArrayDecoder.java
index 2acb5625fba..9a741837d1a 100644
---
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketByteArrayDecoder.java
+++
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketByteArrayDecoder.java
@@ -25,10 +25,14 @@
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.DefaultAddressedEnvelope;
import io.netty.handler.codec.MessageToMessageDecoder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
@ChannelHandler.Sharable
public class DatagramPacketByteArrayDecoder extends
MessageToMessageDecoder<AddressedEnvelope<Object, InetSocketAddress>> {
+ private static final Logger LOG =
LoggerFactory.getLogger(DatagramPacketByteArrayDecoder.class);
+
private DelegateByteArrayDecoder delegateDecoder = new
DelegateByteArrayDecoder();
@Override
@@ -38,6 +42,8 @@ protected void decode(ChannelHandlerContext ctx,
AddressedEnvelope<Object, InetS
byte[] content = (byte[]) out.remove(out.size() - 1);
AddressedEnvelope<Object, InetSocketAddress> addressedEnvelop =
new DefaultAddressedEnvelope<>(content, msg.recipient(), msg.sender());
out.add(addressedEnvelop);
+ } else {
+ LOG.debug("Ignoring message content as it is not an
io.netty.buffer.ByteBuf instance.");
}
}
diff --git
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketByteArrayEncoder.java
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketByteArrayEncoder.java
index 6273f074028..31b98600b59 100644
---
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketByteArrayEncoder.java
+++
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketByteArrayEncoder.java
@@ -25,10 +25,14 @@
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.DefaultAddressedEnvelope;
import io.netty.handler.codec.MessageToMessageEncoder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
@ChannelHandler.Sharable
public class DatagramPacketByteArrayEncoder extends
MessageToMessageEncoder<AddressedEnvelope<Object, InetSocketAddress>> {
+ private static final Logger LOG =
LoggerFactory.getLogger(DatagramPacketByteArrayEncoder.class);
+
private DelegateByteArrayEncoder delegateEncoder = new
DelegateByteArrayEncoder();
@Override
@@ -38,6 +42,8 @@ protected void encode(ChannelHandlerContext ctx,
AddressedEnvelope<Object, InetS
ByteBuf buf = (ByteBuf) out.remove(out.size() - 1);
AddressedEnvelope<Object, InetSocketAddress> addressedEnvelop =
new DefaultAddressedEnvelope<>(buf.retain(), msg.recipient(), msg.sender());
out.add(addressedEnvelop);
+ } else {
+ LOG.debug("Ignoring message content as it is not a byte[]
instance.");
}
}
diff --git
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketDelimiterDecoder.java
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketDelimiterDecoder.java
index ffc947d4d33..fb51a31ea26 100644
---
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketDelimiterDecoder.java
+++
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketDelimiterDecoder.java
@@ -24,8 +24,13 @@
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.DefaultAddressedEnvelope;
import io.netty.handler.codec.MessageToMessageDecoder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class DatagramPacketDelimiterDecoder extends
MessageToMessageDecoder<AddressedEnvelope<Object, InetSocketAddress>> {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(DatagramPacketDelimiterDecoder.class);
+
private final DelimiterBasedFrameDecoder delegateDecoder;
public DatagramPacketDelimiterDecoder(int maxFrameLength, ByteBuf[]
delimiters) {
@@ -45,8 +50,9 @@ protected void decode(ChannelHandlerContext ctx,
AddressedEnvelope<Object, InetS
AddressedEnvelope<Object, InetSocketAddress> addressEvelop =
new DefaultAddressedEnvelope<>(result, msg.recipient(),
msg.sender());
out.add(addressEvelop);
+ } else {
+ LOG.debug("Ignoring message content as it is not an
io.netty.buffer.ByteBuf instance.");
}
-
}
}
diff --git
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketEncoder.java
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketEncoder.java
index c194763a4e9..4e853e70e03 100644
---
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketEncoder.java
+++
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketEncoder.java
@@ -25,10 +25,14 @@
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.socket.DatagramPacket;
import io.netty.handler.codec.MessageToMessageEncoder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
@Sharable
public class DatagramPacketEncoder extends
MessageToMessageEncoder<AddressedEnvelope<Object, InetSocketAddress>> {
+ private static final Logger LOG =
LoggerFactory.getLogger(DatagramPacketEncoder.class);
+
@Override
protected void encode(ChannelHandlerContext ctx, AddressedEnvelope<Object,
InetSocketAddress> msg, List<Object> out) throws Exception {
if (msg.content() instanceof ByteBuf) {
@@ -36,6 +40,8 @@ protected void encode(ChannelHandlerContext ctx,
AddressedEnvelope<Object, InetS
// Just wrap the message as DatagramPacket, need to make sure the
message content is ByteBuf
DatagramPacket dp = new DatagramPacket(payload.retain(),
msg.recipient());
out.add(dp);
+ } else {
+ LOG.debug("Ignoring message content as it is not an
io.netty.buffer.ByteBuf instance.");
}
}
diff --git
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketObjectEncoder.java
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketObjectEncoder.java
index 6264a9f9b9c..19015a42b7e 100644
---
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketObjectEncoder.java
+++
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketObjectEncoder.java
@@ -26,10 +26,13 @@
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.DefaultAddressedEnvelope;
import io.netty.handler.codec.MessageToMessageEncoder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
@Sharable
public class DatagramPacketObjectEncoder extends
MessageToMessageEncoder<AddressedEnvelope<Object, InetSocketAddress>> {
+ private static final Logger LOG =
LoggerFactory.getLogger(DatagramPacketObjectEncoder.class);
private ObjectEncoder delegateObjectEncoder;
public DatagramPacketObjectEncoder() {
delegateObjectEncoder = new ObjectEncoder();
@@ -44,8 +47,9 @@ protected void encode(ChannelHandlerContext ctx,
AddressedEnvelope<Object, InetS
AddressedEnvelope<Object, InetSocketAddress> addressedEnvelop =
new DefaultAddressedEnvelope<>(buf, msg.recipient(),
msg.sender());
out.add(addressedEnvelop);
+ } else {
+ LOG.debug("Ignoring message content as it is not a
java.io.Serializable instance.");
}
-
}
}
diff --git
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketStringDecoder.java
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketStringDecoder.java
index 5317ecc3d46..43525f9a580 100644
---
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketStringDecoder.java
+++
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketStringDecoder.java
@@ -26,10 +26,14 @@
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.DefaultAddressedEnvelope;
import io.netty.handler.codec.MessageToMessageDecoder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
@Sharable
public class DatagramPacketStringDecoder extends
MessageToMessageDecoder<AddressedEnvelope<Object, InetSocketAddress>> {
-
+
+ private static final Logger LOG =
LoggerFactory.getLogger(DatagramPacketStringDecoder.class);
+
private final Charset charset;
/**
@@ -56,6 +60,8 @@ protected void decode(ChannelHandlerContext ctx,
AddressedEnvelope<Object, InetS
AddressedEnvelope<Object, InetSocketAddress> addressedEnvelop =
new DefaultAddressedEnvelope<>(payload.toString(charset),
msg.recipient(), msg.sender());
out.add(addressedEnvelop);
+ } else {
+ LOG.debug("Ignoring message content as it is not an
io.netty.buffer.ByteBuf instance.");
}
}
diff --git
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketStringEncoder.java
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketStringEncoder.java
index fa09b5c1e76..9f735d62a56 100644
---
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketStringEncoder.java
+++
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/codec/DatagramPacketStringEncoder.java
@@ -28,11 +28,15 @@
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.DefaultAddressedEnvelope;
import io.netty.handler.codec.MessageToMessageEncoder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
@Sharable
public class DatagramPacketStringEncoder extends
MessageToMessageEncoder<AddressedEnvelope<Object, InetSocketAddress>> {
+ private static final Logger LOG =
LoggerFactory.getLogger(DatagramPacketStringEncoder.class);
+
private final Charset charset;
/**
@@ -63,6 +67,8 @@ protected void encode(ChannelHandlerContext ctx,
AddressedEnvelope<Object, InetS
AddressedEnvelope<Object, InetSocketAddress> addressedEnvelop =
new
DefaultAddressedEnvelope<>(ByteBufUtil.encodeString(ctx.alloc(),
CharBuffer.wrap(payload), charset), msg.recipient(), msg.sender());
out.add(addressedEnvelop);
+ } else {
+ LOG.debug("Ignoring message content as it is not a
java.lang.CharSequence instance.");
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Camel-netty4: Add DEBUG log when codecs does not apply to the provided content
> ------------------------------------------------------------------------------
>
> Key: CAMEL-12813
> URL: https://issues.apache.org/jira/browse/CAMEL-12813
> Project: Camel
> Issue Type: Improvement
> Affects Versions: 2.23.0
> Reporter: Alex Dettinger
> Assignee: Alex Dettinger
> Priority: Minor
> Fix For: 2.23.0
>
>
> See more context in
> [http://camel.465427.n5.nabble.com/UDP-Netty4-vs-Mina2-td5823354.html|http://camel.465427.n5.nabble.com/UDP-Netty4-vs-Mina2-td5823354.html].
> A possible solution to offer quicker insights would be to add a DEBUG log
> when codecs from the org.apache.camel.component.netty4.codec package does not
> apply to the incoming content.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
