[
https://issues.apache.org/jira/browse/CAMEL-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652364#comment-16652364
]
ASF GitHub Bot commented on CAMEL-12888:
----------------------------------------
onderson commented on a change in pull request #2567: CAMEL-12888: Fixed the
short java type generation in camel-package-ma…
URL: https://github.com/apache/camel/pull/2567#discussion_r225686902
##########
File path:
tooling/maven/camel-package-maven-plugin/src/test/java/org/apache/camel/maven/packaging/model/ComponentOptionModelTest.java
##########
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.maven.packaging.model;
+
+import java.util.stream.Stream;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
+
+import static org.junit.jupiter.params.provider.Arguments.arguments;
+
+public class ComponentOptionModelTest {
+
+ ComponentOptionModel componentOptionModelUnderTest;
+
+ @BeforeEach
+ public void setup() {
+ componentOptionModelUnderTest = new ComponentOptionModel();
+ }
+
+ static Stream<Arguments> getShortJavaTypeVarations() {
+ return Stream.of(
+ arguments("String", "String"),
+ arguments("String", "java.lang.String"),
+ arguments("List", "List<String>"),
+ arguments("List", "java.util.List<String>"),
+ arguments("List", "List<java.lang.String>"),
Review comment:
maybe such as of nesting generic types as the following
`
java.util.List<java.util.Map<java.lang.String,java.lang.Integer>>
`
can also be added?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> The camel-maven-package-plugin issue wrong short java type
> ----------------------------------------------------------
>
> Key: CAMEL-12888
> URL: https://issues.apache.org/jira/browse/CAMEL-12888
> Project: Camel
> Issue Type: Bug
> Components: tooling
> Affects Versions: 2.23.0
> Reporter: Alex Dettinger
> Assignee: Alex Dettinger
> Priority: Minor
>
> For instance, [the seda component documentation
> |https://github.com/apache/camel/blob/master/camel-core/src/main/docs/seda-component.adoc]
> exhibits *Exchange>* as the type for the option *defaultQueueFactory*
> whereas we should issue *BlockingQueueFactory*.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
