[ 
https://issues.apache.org/jira/browse/CAMEL-13724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882732#comment-16882732
 ] 

Andrea Cosentino commented on CAMEL-13724:
------------------------------------------

[~ffang] this seems to break the restlet tests

 

[ERROR] Failures: 
[ERROR] 
org.apache.camel.component.restlet.RestRestletCorsTest.testCors(org.apache.camel.component.restlet.RestRestletCorsTest)
[ERROR] Run 1: 
RestRestletCorsTest.testCors:43->Assert.assertEquals:144->Assert.assertEquals:118->Assert.failNotEquals:834->Assert.fail:88
 expected:<https://localhost:443> but was:<null>
[ERROR] Run 2: 
RestRestletCorsTest.testCors:43->Assert.assertEquals:144->Assert.assertEquals:118->Assert.failNotEquals:834->Assert.fail:88
 expected:<https://localhost:443> but was:<null>
[ERROR] Run 3: 
RestRestletCorsTest.testCors:43->Assert.assertEquals:144->Assert.assertEquals:118->Assert.failNotEquals:834->Assert.fail:88
 expected:<https://localhost:443> but was:<null>
[INFO] 
[ERROR] 
org.apache.camel.component.restlet.RestRestletCorsTest.testRestletProducerGet(org.apache.camel.component.restlet.RestRestletCorsTest)
[ERROR] Run 1: 
RestRestletCorsTest.testRestletProducerGet:60->Assert.assertThat:923->Assert.assertThat:956
 
Expected: is "https://localhost:443";
 but: was null
[ERROR] Run 2: 
RestRestletCorsTest.testRestletProducerGet:60->Assert.assertThat:923->Assert.assertThat:956
 
Expected: is "https://localhost:443";
 but: was null
[ERROR] Run 3: 
RestRestletCorsTest.testRestletProducerGet:60->Assert.assertThat:923->Assert.assertThat:956
 
Expected: is "https://localhost:443";
 but: was null
[INFO] 
[ERROR] 
org.apache.camel.component.restlet.RestRestletGetCorsTest.testCors(org.apache.camel.component.restlet.RestRestletGetCorsTest)
[ERROR] Run 1: 
RestRestletGetCorsTest.testCors:39->Assert.assertEquals:144->Assert.assertEquals:118->Assert.failNotEquals:834->Assert.fail:88
 expected:<*> but was:<null>
[ERROR] Run 2: 
RestRestletGetCorsTest.testCors:39->Assert.assertEquals:144->Assert.assertEquals:118->Assert.failNotEquals:834->Assert.fail:88
 expected:<*> but was:<null>
[ERROR] Run 3: 
RestRestletGetCorsTest.testCors:39->Assert.assertEquals:144->Assert.assertEquals:118->Assert.failNotEquals:834->Assert.fail:88
 expected:<*> but was:<null>

> camel route customized id isn't correct if there are more than one Rest DSL 
> route availble
> ------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-13724
>                 URL: https://issues.apache.org/jira/browse/CAMEL-13724
>             Project: Camel
>          Issue Type: Bug
>          Components: rest
>    Affects Versions: 2.23.3, 2.24.1
>            Reporter: Freeman Fang
>            Assignee: Freeman Fang
>            Priority: Major
>             Fix For: 3.0.0, 2.23.4, 2.24.2, 2.25.0, 3.0.0.M4
>
>
> If rest dsl routes have their own customer ids, the id would be ignored, 
> hence generate  invalid swagger operation Id 
> the testcase here can expose this problem
> {code}
> --- 
> a/core/camel-core/src/test/java/org/apache/camel/impl/RouteIdRestDefinitionTest.java
> +++ 
> b/core/camel-core/src/test/java/org/apache/camel/impl/RouteIdRestDefinitionTest.java
> @@ -39,7 +39,8 @@ public class RouteIdRestDefinitionTest extends 
> ContextTestSupport {
>              public void configure() throws Exception {
>                  from("direct:start1?timeout=30000").to("mock:result");
>                  from("direct:start2").to("mock:result");
> -                
> rest("/say/hello").get("/bar").id("getSayHelloBar").to("mock:result");
> +                
> rest("/say/hello").get("/bar").id("getSayHelloBar").to("mock:result")
> +                
> .get("/bar/{user}").id("getSayHelloBarWithUser").to("mock:result");
>              }
>          };
>      }
> @@ -47,6 +48,7 @@ public class RouteIdRestDefinitionTest extends 
> ContextTestSupport {
>      @Test
>      public void testSayHelloBar() {
>          assertEquals("getSayHelloBar", 
> context.getRouteDefinitions().get(2).getId());
> +        assertEquals("getSayHelloBarWithUser", 
> context.getRouteDefinitions().get(3).getId());
>      }
>      
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to