[
https://issues.apache.org/jira/browse/CAMEL-14047?focusedWorklogId=325912&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325912
]
ASF GitHub Bot logged work on CAMEL-14047:
------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/19 20:47
Start Date: 09/Oct/19 20:47
Worklog Time Spent: 10m
Work Description: williamthompson-toast commented on pull request #3237:
CAMEL-14047: Allow null producerName to get unique name from Pulsar
URL: https://github.com/apache/camel/pull/3237
Addresses [CAMEL-14047](https://issues.apache.org/jira/browse/CAMEL-14047)
### Motivation
Current default producerName value causes a `null` `producerName` to be
impossible when configuring from URI. This causes the code [regarding a null
producerName in the
PulsarProducer](https://github.com/apache/camel/blob/10de4bab2e76046b9535128bf38bf67b80c3f3f4/components/camel-pulsar/src/main/java/org/apache/camel/component/pulsar/PulsarProducer.java#L60-L62)
to be impossible to get to from a URI. This forces anyone wanting to start 2
producers on the same topic in Camel to generate unique IDs and append them to
each `producerName` value.
### Modifications
The fix proposed in this PR is defaulting `producerName` to null and,
instead of generating a `producerName` on a null within Camel, to use Pulsar
`ProducerBuilder`'s automatic generation of a globally unique `producerName`
value as described in the [ProducerBuilder
documentation](https://pulsar.apache.org/api/client/org/apache/pulsar/client/api/ProducerBuilder.html#producerName-java.lang.String-).
### Testing
`PulsarProducerUndefinedProducerNameInTest`: Used to verify that two
producers can bind and send messages when not defining a `producerName` value
in the URI.
### Documentation
Modified `pulsar-component.adoc` with updated information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 325912)
Remaining Estimate: 0h
Time Spent: 10m
> camel-pulsar: Allow Pulsar to auto-select the unique producerName
> -----------------------------------------------------------------
>
> Key: CAMEL-14047
> URL: https://issues.apache.org/jira/browse/CAMEL-14047
> Project: Camel
> Issue Type: Improvement
> Components: camel-pulsar
> Affects Versions: 3.x, 2.24.2
> Reporter: William Thompson
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Current default producerName value causes a null producerName to be
> impossible when configuring from URI. This causes [the code regarding a null
> producerName in the
> PulsarProducer|[https://github.com/apache/camel/blob/10de4bab2e76046b9535128bf38bf67b80c3f3f4/components/camel-pulsar/src/main/java/org/apache/camel/component/pulsar/PulsarProducer.java#L60-L62]]
> to be impossible to hit from a URI. This forces anyone wanting to start 2
> producers on the same topic in Camel to generate unique IDs and append them
> to each producerName value.
> The fix proposed is defaulting producerName to null and, instead of
> generating a producerName on a null within Camel, to use Pulsar
> ProducerBuilder's automatic generation of a globally unique producerName
> value as described in the [ProducerBuilder
> documentation|[https://pulsar.apache.org/api/client/org/apache/pulsar/client/api/ProducerBuilder.html#producerName-java.lang.String-]].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
