[
https://issues.apache.org/jira/browse/CAMEL-13752?focusedWorklogId=334223&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334223
]
ASF GitHub Bot logged work on CAMEL-13752:
------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Oct/19 16:12
Start Date: 25/Oct/19 16:12
Worklog Time Spent: 10m
Work Description: srdo commented on pull request #3283: CAMEL-13752:
Reimplement BridgePropertyPlaceholderConfigurer to extend
PropertySourcesPlaceholderCOnfigurer
URL: https://github.com/apache/camel/pull/3283
This makes the BridgePropertyPlaceholderConfigurer extend the newer
PropertySourcesPlaceholderConfigurer, instead of the
PropertyPlaceholderConfigurer. See
https://issues.apache.org/jira/browse/CAMEL-13752.
The first commit implements this change based on changes to the
PropertySourcesPlaceholderConfigurer from
https://github.com/spring-projects/spring-framework/pull/23377. The second
commit makes changes to make this PR independent of those changes. If/when
Spring merges the linked PR, the changes from commit 2 can be reverted to
reduce how much adaptation code is in Camel for the
PropertySourcesPlaceholderConfigurer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 334223)
Remaining Estimate: 0h
Time Spent: 10m
> Make a BridgePropertyPlaceholderConfigurer equivalent for
> PropertySourcePlaceholderConfigurer
> ---------------------------------------------------------------------------------------------
>
> Key: CAMEL-13752
> URL: https://issues.apache.org/jira/browse/CAMEL-13752
> Project: Camel
> Issue Type: New Feature
> Components: camel-spring
> Affects Versions: 2.24.1, 3.0.0.M4
> Reporter: Stig Rohde Døssing
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> BridgePropertyPlaceholderConfigurer extends Spring's
> PropertyPlaceholderConfigurer. Spring recommends against using this class for
> new code, and has a replacement in the PropertySourcesPlaceholderConfigurer.
> The new class is a prerequisite for e.g. the @TestPropertySource annotation
> to work. Example usage here
> https://github.com/apache/camel/blob/camel-2.23.1/components/camel-test-spring/src/test/java/org/apache/camel/test/spring/CamelSpringRunnerTestPropertySourceTest.java
> It's not obvious to me whether it would be safe to reimplement
> BridgePropertyPlaceholderConfigurer to extend
> PropertySourcesPlaceholderConfigurer instead. I'd guess it wouldn't be
> backwards compatible, otherwise Spring would probably have just reimplemented
> PropertyPlaceholderConfigurer.
> I think we should add a new BridgePropertySourcesPlaceholderConfigurer that
> extends PropertySourcesPlaceholderConfigurer. This will allow users to use
> the Camel property bridging functionality, without losing the ability to
> override Spring properties in tests.
> I am happy to work on this if the idea makes sense.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
