[
https://issues.apache.org/jira/browse/CAMEL-14374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009833#comment-17009833
]
Jiri Ondrusek commented on CAMEL-14374:
---------------------------------------
Ok, no problem with this approach.
It will only need some more refactoring, as parameter channels is not defined
in model.
[~davsclaus] Just to be sure, following syntax option works (in master) -
irc:nick@host[:port]/#room[?options] - if I remove it from doc (as model
doesn't support it), should it still work as before?
I was planning to create issue (enhancement) to get rid of deprecated sanitize
method and keep parsing only according to the model -
https://github.com/apache/camel/blob/master/components/camel-irc/src/main/java/org/apache/camel/component/irc/IrcConfiguration.java#L502
I can imagine, that by slight change in model, it will allow both url syntaxes
without breaking back compatibility. From my point of view it would be nice,
to have the same functionality as is now, but incorporated also in the model
and ideally get rid of deprecated method. What do you think?
(it works because of this sanitize method ...)
> Camel-irc validation of endpoint's url fails for correct url
> ------------------------------------------------------------
>
> Key: CAMEL-14374
> URL: https://issues.apache.org/jira/browse/CAMEL-14374
> Project: Camel
> Issue Type: Task
> Components: camel-irc
> Affects Versions: 3.1.0
> Reporter: Jiri Ondrusek
> Assignee: Jiri Ondrusek
> Priority: Trivial
>
> According to documentation
> https://camel.apache.org/components/latest/irc-component.html there are two
> options for endpoint urls:
> * irc:nick@host[:port]/#room[?options]
> * irc:nick@host[:port]?channels=#channel1,#channel2,#channel3[?options]
> But both of these urls are not valid according to camel validations (e.g.
> validation by plugins)
> "Invalid integer value 6667/#test" or "option "channels" from doc is not part
> of the model, hence it is not valid"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
