[
https://issues.apache.org/jira/browse/CAMEL-14506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031439#comment-17031439
]
Jiri Ondrusek edited comment on CAMEL-14506 at 2/6/20 10:20 AM:
----------------------------------------------------------------
[~davsclaus]
should I also disable stepwise function in stream download (which would force
behavior to be correct, but also will be unclear for user)
Better approach would be to throw an error if stepwise is true during stream
download.
Or just the doc update. What do you think?
was (Author: jondruse):
[~davsclaus]
should I also disable stepwise function in stream download (which would force
behavior to be correct, but also will be unclear for user)
Better approach would be to throw an error if stepwise is true during stream
download. What do you think?
> came-ftp - streamDownload=true and stepwise=true for larger files could cause
> deadlock
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-14506
> URL: https://issues.apache.org/jira/browse/CAMEL-14506
> Project: Camel
> Issue Type: Bug
> Components: camel-ftp
> Affects Versions: 3.1.0
> Reporter: Jiri Ondrusek
> Assignee: Jiri Ondrusek
> Priority: Major
>
> If downloading files of size bigger then about 0,5 MB (differs on other
> parameters) with option streamDownload=true and stepwise=true (default
> values), operation could freeze (on my local environment it freezes with 100%
> certainty), because retrieved inputstream has to be closed before calling
> other commands .
> See
> https://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/ftp/FTPClient.html#retrieveFileStream(java.lang.String)
> {quote}To finalize the file transfer you must call completePendingCommand and
> check its return value to verify success. If this is not done, subsequent
> commands may behave unexpectedly.{quote}
> Problem happens if retrieval of file is immediately followed by change of
> directory.
> I can imagine fix, which doesn't make change of directory, if is not
> necessary and it would be nice to add note to documentation, that
> streamDownload and stepWise options together could cause unexpected behavior
> for larger filespossibly (possible freeze of component)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
