[
https://issues.apache.org/jira/browse/CAMEL-14506?focusedWorklogId=384372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384372
]
ASF GitHub Bot logged work on CAMEL-14506:
------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/20 11:55
Start Date: 10/Feb/20 11:55
Worklog Time Spent: 10m
Work Description: JiriOndrusek commented on pull request #3560:
CAMEL-14506 came-ftp - streamDownload and stepwise could cause deadlock
URL: https://github.com/apache/camel/pull/3560
Issue: https://issues.apache.org/jira/browse/CAMEL-14506
Stepwise and stream download are not supported together.
Combination of these two parameters in ftp component is strictly forbidden
(could cause freeze). IllegalArgumentException is now thrown when this options
are used together.
A new test covering this change is introduced:
FtpSimpleConsumeStreamingStepwiseTrueTest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 384372)
Remaining Estimate: 0h
Time Spent: 10m
> came-ftp - streamDownload=true and stepwise=true for larger files could cause
> deadlock
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-14506
> URL: https://issues.apache.org/jira/browse/CAMEL-14506
> Project: Camel
> Issue Type: Bug
> Components: camel-ftp
> Affects Versions: 3.1.0
> Reporter: Jiri Ondrusek
> Assignee: Jiri Ondrusek
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If downloading files of size bigger then about 0,5 MB (differs on other
> parameters) with option streamDownload=true and stepwise=true (default
> values), operation could freeze (on my local environment it freezes with 100%
> certainty), because retrieved inputstream has to be closed before calling
> other commands .
> See
> https://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/ftp/FTPClient.html#retrieveFileStream(java.lang.String)
> {quote}To finalize the file transfer you must call completePendingCommand and
> check its return value to verify success. If this is not done, subsequent
> commands may behave unexpectedly.{quote}
> Problem happens if retrieval of file is immediately followed by change of
> directory.
> I can imagine fix, which doesn't make change of directory, if is not
> necessary and it would be nice to add note to documentation, that
> streamDownload and stepWise options together could cause unexpected behavior
> for larger filespossibly (possible freeze of component)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
