Andrea Tarocchi created CAMEL-14540:
---------------------------------------
Summary: Change the switch/case indentation sourcecheck policy
Key: CAMEL-14540
URL: https://issues.apache.org/jira/browse/CAMEL-14540
Project: Camel
Issue Type: Improvement
Reporter: Andrea Tarocchi
Since recently I have been playing with our sourcheck to hook it in as a GitHub
action at each PR, I have been fixing some sourcecheck findings leftover from
previous unchecked commits.
Most of the stuff makes sense but this one:
{code:xml}
// Some comments here
<module name="Indentation">
<property name="lineWrappingIndentation" value="0"/>
<property name="caseIndent" value="0"/>
</module>
{code}
this impose that switch/case blocks should be in the form of:
{code:java}
switch(...) {
case:
...
case:
...
case:
...
default:
}
{code}
i.e. {{switch}} and {{case}} keywords MUST have the same indentation. I have
searched a little bit and it seems this is not widely used as a code style, the
tendency is to have the {{case}} indented.
Since there are 2053 occurrences of switch/case blocks, before attempting to
fix this I would like a general agreement on this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
