[ 
https://issues.apache.org/jira/browse/CAMEL-14607?focusedWorklogId=390770&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390770
 ]

ASF GitHub Bot logged work on CAMEL-14607:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Feb/20 16:57
            Start Date: 21/Feb/20 16:57
    Worklog Time Spent: 10m 
      Work Description: connormcauliffe-toast commented on pull request #3594: 
CAMEL-14607: support negative acknowledge in pulsar message receipt
URL: https://github.com/apache/camel/pull/3594
 
 
   Addresses [Camel-14607](https://issues.apache.org/jira/browse/CAMEL-14607)
   
   **Motivation**
   Recently the pulsar version got updated to 2.5.0. In the new version of 
Pulsar, the negative acknowledgement is now a supported operation and we want 
to add support for that in Camel as well. This replaces the 
UnsupportedOperationException with the now supported `negativeAcknowledge` call.
   
   **Verifying the change**
   A test has been added to the `PulsarConsumerAcknowledgementTest` class which 
verifies that the negativeAck call redelivers the message. The test which 
verified the negativeAck call threw an UnsupportedOperationException has also 
been removed. 
   
   **Additional Change**
   There are minor changes in other test files which just remove deprecated 
Camel testing features. These were simply done to remove the warnings during 
the mvn build.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 390770)
    Remaining Estimate: 0h
            Time Spent: 10m

> Camel-Pulsar add Negative ack support
> -------------------------------------
>
>                 Key: CAMEL-14607
>                 URL: https://issues.apache.org/jira/browse/CAMEL-14607
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-pulsar
>            Reporter: Connor McAuliffe
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the upgrade to camel-3, the pulsar version also got updated, meaning that 
> negative acks are now supported. Currently the DefaultPulsarMessageReceipt 
> throws an UnsupportedOperationException if you try to negative ack. Now that 
> it is supported we can change the function to actually negative ack.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to