[
https://issues.apache.org/jira/browse/CAMEL-14743?focusedWorklogId=409549&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409549
]
ASF GitHub Bot logged work on CAMEL-14743:
------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/20 14:50
Start Date: 25/Mar/20 14:50
Worklog Time Spent: 10m
Work Description: JiriOndrusek commented on pull request #3679:
CAMEL-14743 camel-elytron: use UndertowSecurityProvider API
URL: https://github.com/apache/camel/pull/3679
Issue: https://issues.apache.org/jira/browse/CAMEL-14743
Fix contains refactor of camel-elytron to use UndertowSecurityProvider (see
https://issues.apache.org/jira/browse/CAMEL-14208)
Changes introduces new ElytronSecurityProvider.java and removes elytron as a
component (since now it is only plugin for camel-undertow)
JUnit test covers basic token bearer scenario.
I'm not sure about following changes:
- I've removed ElytronComponent (and all generated files linked to it)
- I've changed documentation to not contain component (and starter)
parameters (I've changed 'since' attribute to 3.2 - I'm not sure whether it is
'the same' component as before or not)
- location of files is still the same
Following step is:
- to remove of camel-elytron-starter
(https://github.com/apache/camel-spring-boot/tree/master/components-starter/camel-elytron-starter)
!!! It makes sense to remove starter first (to prevent compilation issues
with dev profile). Once this PR is approved, I can remove starter (after
creating a jira issue) and after removal of the starter, this PR could be
merged.
[ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change
(usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line
and body.
[ ] If you're unsure, you can format the pull request title like
`[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX`
with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
[ ] Run `mvn clean install -Psourcecheck` in your module with source check
enabled to make sure basic checks pass and there are no checkstyle violations.
A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 409549)
Remaining Estimate: 0h
Time Spent: 10m
> camel-elytron: refactor component to use new SPI interface from camel-undertow
> ------------------------------------------------------------------------------
>
> Key: CAMEL-14743
> URL: https://issues.apache.org/jira/browse/CAMEL-14743
> Project: Camel
> Issue Type: Task
> Components: camel-undertow
> Affects Versions: 3.2.0
> Reporter: Jiri Ondrusek
> Assignee: Jiri Ondrusek
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As a part of the fix of https://issues.apache.org/jira/browse/CAMEL-14208
> there is a new SPI APi for security providers. Component camel-elytron should
> be refactored to use that api.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
