[ 
https://issues.apache.org/jira/browse/CAMEL-14883?focusedWorklogId=420846&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420846
 ]

ASF GitHub Bot logged work on CAMEL-14883:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/20 00:47
            Start Date: 12/Apr/20 00:47
    Worklog Time Spent: 10m 
      Work Description: eicki commented on pull request #3731: CAMEL-14883 
CamelBeanPostProcessor implements Ordered interface provided by Spring  with 
lowest precedence
URL: https://github.com/apache/camel/pull/3731
 
 
   This avoids issues e.g. described in 
https://github.com/spring-projects/spring-framework/issues/24058 and 
additionally according to Spring it is best practice to have BeanPostProcessors 
implement Ordered interface.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 420846)
    Remaining Estimate: 0h
            Time Spent: 10m

> Make CamelBeanPostProcessor implement Ordered
> ---------------------------------------------
>
>                 Key: CAMEL-14883
>                 URL: https://issues.apache.org/jira/browse/CAMEL-14883
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 3.2.0
>            Reporter: Eickvonder
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The CamelBeanPostProcessor does not implement the Ordered interface provided 
> by Spring.
> According to Spring documentation it is recommended to do so:
> {panel:title=[https://docs.spring.io/spring/docs/current/spring-framework-reference/core.html#beans-factory-extension-bpp]}
> If you write your own {{BeanPostProcessor}}, you should consider implementing 
> the {{Ordered}} interface, too
> {panel}
> And not doing so may break certain things (see e.g. 
> https://github.com/spring-projects/spring-framework/issues/24058) but Spring 
> guys won't fix that to keep backwards-compatibility. So I would suggest to 
> let the CamelBeanPostProcessor implement the Ordered interface, e.g. with 
> lowest priority or with configurable priority. The actual value is 
> irrelevant, the issue described in 
> https://github.com/spring-projects/spring-framework/issues/24058 only occurs 
> if a post processor exists that does not implement the ordered interface.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to