[
https://issues.apache.org/jira/browse/CAMEL-14958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146155#comment-17146155
]
ASF GitHub Bot commented on CAMEL-14958:
----------------------------------------
zregvart commented on pull request #398:
URL: https://github.com/apache/camel-website/pull/398#issuecomment-650085261
> I don't realize what part is complex yet as I now use only one input and
make use of flex box and everything else is css based on the breakpoint?
The complexity I see is from adding conditionals to the navigation panel
rendering the components reference and that a lot of positioning seems to be
done by finding the values and putting them in, rather than deriving them from
variables/using `calc`. What I see as a problem is that if we change, say the
height of the navbar, this positioning needs to be recalculated again. There's
also the element that was added to ensure the break on smaller screens, I'm not
sure that it's needed. Using flex layout with `float`. Overall if you look at
the changes here and the outcome from those it seems like a lot of changes for
not that many changes in the output. I think if we were to redo this knowing
the principles that are needed for this change, carefully adding/changing only
the CSS that needs to be changed, we'd end up with 33%-50% of the CSS we have
now.
Anyhow don't let that discourage you, this is excellent work, keep polishing
this, we can use a lot of it and hopefully merge it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Suggestion on search bar within smaller screen width.
> -----------------------------------------------------
>
> Key: CAMEL-14958
> URL: https://issues.apache.org/jira/browse/CAMEL-14958
> Project: Camel
> Issue Type: Improvement
> Components: website
> Reporter: Aemie
> Priority: Major
> Labels: outreachy2020, suggestions
> Attachments: bootstrap-design-blog.png,
> bootstrap-design-frontpage.png, design-frontpage.png, design-navbar.png,
> inline-search.png, issue-facing.png, nav-search-icon-1220.png,
> nav-searchbar-1220.png, nav-searchbar-414.png, navbar-search-414.png,
> navbar-searchbar.png, transform-method.png
>
>
> Within the small width screen, the setting is to only display the social icon
> button as of now. However, I thought it would be a good idea to include the
> search icon alongside the social button icons. On click of the social button
> icons, we could include animation, for instance, a fade-in effect of the
> search bar occupying the entire navbar. The user can do the search as
> required. On the left side of the search bar, there will be back arrow, which
> on click would give us the original navbar look with a fade-out effect.
> Before I start working on this, I would like an opinion about this idea.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
