[
https://issues.apache.org/jira/browse/CAMEL-15360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169378#comment-17169378
]
ASF GitHub Bot commented on CAMEL-15360:
----------------------------------------
zregvart commented on a change in pull request #443:
URL: https://github.com/apache/camel-website/pull/443#discussion_r463985824
##########
File path: layouts/partials/footer.html
##########
@@ -6,66 +6,50 @@
</div>
<footer>
<div class="footer">
+ <figure class="logo">
+ <img class="logo" src="/_/img/logo-d.svg" alt="Apache Camel
Logo"
+ aria-label="white silhouette of a camel in front of a sand
dune">
+ </figure>
+ <input id="footer-toggle-overview" type="checkbox"
title="Show/Hide Overview section" />
<dl>
- <figure class="logo">
- <img class="logo" src="/_/img/logo-d.svg" alt="Apache
Camel Logo"
- aria-label="white silhouette of a camel in front of a
sand dune">
- </figure>
- <dt>Overview</dt>
- <input type="checkbox" id="show-overview"/>
- <label for="show-overview"><img class="show-menu"
src="/_/img/show-footer-menu.svg"></label>
- <label for="show-overview"><img class="hide-menu"
src="/_/img/hide-footer-menu.svg"></label>
- <div class="footer-menu">
- <dd><a href="/blog/">Blog</a></dd>
- <dd><a href="/docs/">Documentation</a></dd>
- <dd><a href="/community/support/">Community</a></dd>
- <dd><a href="/blog/">Download</a></dd>
- </div>
+ <dt><label for="footer-toggle-overview">Overview</label><label
for="footer-toggle-overview">＋</label></dt>
Review comment:
Yeah I was preoccupied with mobile version that I forgot to check the
desktop one. Not sure if assigning `id`s here would be the correct approach.
Assigning same `id` to more than one element is not valid HTML. I've set the
`display: none` via CSS selector: `footer .footer dl dt label:nth-child(2)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> HTML validation issues
> ----------------------
>
> Key: CAMEL-15360
> URL: https://issues.apache.org/jira/browse/CAMEL-15360
> Project: Camel
> Issue Type: Bug
> Components: website
> Reporter: Zoran Regvart
> Assignee: Zoran Regvart
> Priority: Major
>
> Seems that changes in CAMEL-15185 caused HTML [validation
> issues|https://ci-builds.apache.org/job/Camel/job/Camel.website/job/master/7/consoleFull]:
> {code}
> 1:5444 error Element <figure> is not permitted as content in <dl>
> element-permitted-content
> 1:5628 error Element <input> is not permitted as content in <dl>
> element-permitted-content
> 1:5671 error Element <label> is not permitted as content in <dl>
> element-permitted-content
> 1:5698 error <img> is missing required alt attribute
> WCAG/H37
> 1:5766 error Element <label> is not permitted as content in <dl>
> element-permitted-content
> 1:5793 error <img> is missing required alt attribute
> WCAG/H37
> 1:6107 error Element <input> is not permitted as content in <dl>
> element-permitted-content
> 1:6146 error Element <label> is not permitted as content in <dl>
> element-permitted-content
> 1:6169 error <img> is missing required alt attribute
> WCAG/H37
> 1:6237 error Element <label> is not permitted as content in <dl>
> element-permitted-content
> 1:6260 error <img> is missing required alt attribute
> WCAG/H37
> 1:6887 error Element <input> is not permitted as content in <dl>
> element-permitted-content
> 1:6931 error Element <label> is not permitted as content in <dl>
> element-permitted-content
> 1:6959 error <img> is missing required alt attribute
> WCAG/H37
> 1:7027 error Element <label> is not permitted as content in <dl>
> element-permitted-content
> 1:7055 error <img> is missing required alt attribute
> WCAG/H37
> 1:7593 error Element <input> is not permitted as content in <dl>
> element-permitted-content
> 1:7633 error Element <label> is not permitted as content in <dl>
> element-permitted-content
> 1:7657 error <img> is missing required alt attribute
> WCAG/H37
> 1:7725 error Element <label> is not permitted as content in <dl>
> element-permitted-content
> 1:7749 error <img> is missing required alt attribute
> WCAG/H37
> 1:9296 error Duplicate ID "social-media"
> no-dup-id
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
