[
https://issues.apache.org/jira/browse/CAMEL-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169544#comment-17169544
]
ASF GitHub Bot commented on CAMEL-15335:
----------------------------------------
AemieJ commented on a change in pull request #444:
URL: https://github.com/apache/camel-website/pull/444#discussion_r464077068
##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -390,15 +410,45 @@ body {
padding-right: 0.5rem;
}
+#search_results div.result {
+ padding: 0.25rem;
+ pointer-events: none;
+}
+
+#search_results div.result:hover {
+ background: var(--color-smoke-50);
+}
+
+#search_results div.section {
+ display: flex;
+}
+
Review comment:
This doesn't remove scrollbars necessarily. Scrollbars only appear when
the text covered by dl has height > 80vh which occurs in a few cases. Hence, I
suggested using pagination to avoid scrollbars usage. However, for this PR, I
wanted to just have a basic implementation for the search design layout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Search Result Layout
> --------------------
>
> Key: CAMEL-15335
> URL: https://issues.apache.org/jira/browse/CAMEL-15335
> Project: Camel
> Issue Type: Improvement
> Components: website
> Reporter: Aemie
> Priority: Major
> Attachments: algolia-result.png, bootstrap-result.png,
> distributeData.js, search-result#1.png, search-result#3.png,
> search-result-design#2.png
>
>
> The current search result design doesn't fit entirely with the website
> design. Thus, I wanted to introduce a few changes to how we present it. Also,
> in addition to I would like to suggest that we include only the top 5 or top
> 6 results and not 10 as the pages are ranked by weight based on the search
> query and presented so a good practice would show fewer results which are
> precise.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
