[jira] [Commented] (CAMEL-15371) Underline links

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/CAMEL-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175838#comment-17175838
 ] 

ASF GitHub Bot commented on CAMEL-15371:
----------------------------------------

zregvart commented on a change in pull request #452:
URL: https://github.com/apache/camel-website/pull/452#discussion_r468862318



##########
File path: antora-ui-camel/src/css/doc.css
##########
@@ -149,6 +149,16 @@
 .doc a {
   color: var(--link-font-color);
   word-break: break-word;
+  text-decoration: underline;
+  text-underline-position: under;

Review comment:
       Right, so this is with `text-underline-position: under`:
   
   ![Screenshot_2020-08-11 Home - Apache 
Camel](https://user-images.githubusercontent.com/1306050/89947841-5e2b0600-dc25-11ea-87eb-0ee28caca42a.png)
   
   and without:
   
   ![Screenshot_2020-08-11 Home - Apache 
Camel(1)](https://user-images.githubusercontent.com/1306050/89947917-7d299800-dc25-11ea-805b-4bacfc13cc4b.png)
   
   I think what you're reacting to is that the underline is quite noticeable, 
perhaps adding to make it lighter:
   
   ```suggestion
     text-decoration-thickness: 1px;
     text-decoration-style: dotted;
   ```
   
   Would help, this is how it renders in Firefox:
   
   ![Screenshot_2020-08-11 Home - Apache 
Camel(3)](https://user-images.githubusercontent.com/1306050/89948444-70f20a80-dc26-11ea-9a57-b84bd5659c42.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Underline links
> ---------------
>
>                 Key: CAMEL-15371
>                 URL: https://issues.apache.org/jira/browse/CAMEL-15371
>             Project: Camel
>          Issue Type: Improvement
>          Components: website
>            Reporter: Zoran Regvart
>            Priority: Minor
>         Attachments: list-style.png
>
>
> I think links should be underlined by default, this is recommended by [W3 
> accessibility 
> guidelines|https://www.w3.org/WAI/WCAG21/Techniques/general/G183]. Links that 
> resemble buttons should not be underlined.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)