[ 
https://issues.apache.org/jira/browse/CAMEL-16413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312365#comment-17312365
 ] 

Suneet Kumar edited comment on CAMEL-16413 at 3/31/21, 1:02 PM:
----------------------------------------------------------------

Here, it is checking both isStoppingOrStopped() and isSuspendingOrSuspended()
 
[https://github.com/apache/camel/blob/73c674b54df5ff741939629abd4564583f98c199/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConsumer.java#L339]

 

So, shouldn't 
 boolean stopping = isStoppingOrStopped() || isSuspendingOrSuspended();


was (Author: suneetk92):
Here, it is checking both isStoppingOrStopped() and isSuspendingOrSuspended()
[https://github.com/apache/camel/blob/73c674b54df5ff741939629abd4564583f98c199/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConsumer.java#L339]

 

So, shouldn't 
 boolean stopping = isStoppingOrStopped() && isSuspendingOrSuspended();

> [camel-kafka] Avoid committing offsets onPartitionsRevoked during shutdown 
> when autoCommitOnStop is "none"
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-16413
>                 URL: https://issues.apache.org/jira/browse/CAMEL-16413
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-kafka
>    Affects Versions: 3.8.0
>            Reporter: Suneet Kumar
>            Assignee: Claus Ibsen
>            Priority: Major
>             Fix For: 3.10.0
>
>
> During shutdown process, whenever a partition is revoked, 
> `onPartitionsRevoked` method is called, which is forcing `commitSync`  even 
> when `autoCommitOnStop` is set to none.
>  
> ```
>  {{DEBUG org.apache.camel.component.kafka.KafkaConsumer: - 
> onPartitionsRevoked: **-Thread 0 from topic **}}
> {{DEBUG org.apache.camel.component.kafka.KafkaConsumer: - Forcing commitSync 
> **-Thread 0 from topic ** with offset: 31621}}
> ```
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to