[
https://issues.apache.org/jira/browse/CAMEL-17802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513306#comment-17513306
]
Otavio Rodolfo Piske commented on CAMEL-17802:
----------------------------------------------
??I looked at the PR. Are you sure we do not want the *autoCommitOnStop*
anymore? When auto commit is disabled the offset is not commited on consumer
close so I would leave this parameter to allow manual offset commits in case
auto commit is disabled for some reason (like someone wants to control offsets
manually and wants to have control over the offsets when Camel shuts down). I
would just throw an exception in case someone configures both
*autoCommitEnable* and {*}autoCommitOnStop{*}, cause in this case offset will
be commited no matter what autoCommitOnStop has been configured with.??
Thanks for your insights. I am leaning towards removing it altogether. My
understanding is that integrations relaying on manual commits, will do the
final commit themselves on close/shutdown ... but, let me think more about this.
> Check whether we need to manually commit offset upon stop when auto commit is
> enabled
> -------------------------------------------------------------------------------------
>
> Key: CAMEL-17802
> URL: https://issues.apache.org/jira/browse/CAMEL-17802
> Project: Camel
> Issue Type: Improvement
> Components: camel-kafka
> Reporter: Rafał Gała
> Assignee: Otavio Rodolfo Piske
> Priority: Minor
>
> As requested by [~orpiske] in CAMEL-17798.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
