[
https://issues.apache.org/jira/browse/CAMEL-18230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen resolved CAMEL-18230.
---------------------------------
Resolution: Invalid
> Potential Refactoring
> ---------------------
>
> Key: CAMEL-18230
> URL: https://issues.apache.org/jira/browse/CAMEL-18230
> Project: Camel
> Issue Type: Improvement
> Reporter: Alvin Tan Jian Jia
> Priority: Minor
> Labels: refactor
> Attachments: Camel_camel-3.7.0.csv
>
>
> *Summary*
> I have identified a few classes with refactoring potential, specifically
> error handlers . The issue was refactored once on Nov 12, 2020 along with
> other classes in commit d1be1a6bbc11d87d19a52ffcda25f0187a4b4055. Given the
> duration of the last refactoring, could it be possible to improve the overall
> package of error handlers further? I am probably not qualified and
> experienced enough to point out the exact code needs to be refactored, given
> my limited knowledge of the project and codebase.
> *Urgency*
> Low priority. For maintenance of code in the long run.
> Hi,
> I am currently doing some research on Estimating Time Taken for Software
> Refactoring. Camel is one of my case studies being a highly popular project.
> Would appreciate your kind feedback on the appropriateness of the estimated
> time to refactor.
> I am specifically looking at potential for refactoring, such as breaking
> functions that are too long into shorter functions, or to remove code
> duplication. Would you agree that there could be some modification to the
> code to make it better in the listed classes? And if so, is the estimated
> time appropriate to carry out the improvement? I will be grateful for any
> help you can provide.
> # ErrorHandlerRefReifier.java - 2 hours
> # ErrorHandlerReifier.java - 3 hours
> # NoErrorHandlerReifier.java - 1 hour
> # DefaultErrorHandlerReifier.java - 2 hours
> # DeadLetterChannelReifier.java - 1 hour
> # ErrorHandlerHelper.java - 2 hours
> # DefaultErrorHandlerProperties.java - 4 hours
>
> The attached csv file contains the other recommendations from my research.
> Thank you once again for any help you can provide.
>
> Regards,
> Alvin
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
