[ 
https://issues.apache.org/jira/browse/CAMEL-19014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687288#comment-17687288
 ] 

Rhuan Rocha commented on CAMEL-19014:
-------------------------------------

Hi [~andrea81] ,

 I reproduced it here in my local environment and locks like you are correct. 
The issue is about Concurrence. I have seen the following log here

```

[Camel (camel-1) thread #6 - timer://test-timer5] WARN 
org.apache.camel.component.timer.TimerConsumer - Error processing exchange. 
Exchange[4693970F0659A59-000000000000005C]. Caused by: 
[java.util.ConcurrentModificationException - null]
java.util.ConcurrentModificationException
    at 
java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1013)
    at java.base/java.util.ArrayList$Itr.next(ArrayList.java:967)
    at 
org.apache.camel.support.builder.ExpressionBuilder$52.evaluate(ExpressionBuilder.java:1605)
    at 
org.apache.camel.support.ExpressionAdapter.evaluate(ExpressionAdapter.java:45)
    at 
org.apache.camel.model.language.ExpressionDefinition.evaluate(ExpressionDefinition.java:239)
    at 
net.rhuanrocha.SampleLanguageTest.resolveTemplate(SampleLanguageTest.java:145)
    at 
net.rhuanrocha.SampleLanguageTest$1$7.process(SampleLanguageTest.java:133)
    at 
org.apache.camel.support.processor.DelegateSyncProcessor.process(DelegateSyncProcessor.java:65)
    at 
org.apache.camel.processor.errorhandler.RedeliveryErrorHandler$SimpleTask.run(RedeliveryErrorHandler.java:477)
    at 
org.apache.camel.impl.engine.DefaultReactiveExecutor$Worker.schedule(DefaultReactiveExecutor.java:181)
    at 
org.apache.camel.impl.engine.DefaultReactiveExecutor.scheduleMain(DefaultReactiveExecutor.java:59)
    at org.apache.camel.processor.Pipeline.process(Pipeline.java:165)
    at 
org.apache.camel.impl.engine.CamelInternalProcessor.process(CamelInternalProcessor.java:392)
    at 
org.apache.camel.component.timer.TimerConsumer.sendTimerExchange(TimerConsumer.java:210)
    at 
org.apache.camel.component.timer.TimerConsumer$1.run(TimerConsumer.java:76)
    at java.base/java.util.TimerThread.mainLoop(Timer.java:566)
    at java.base/java.util.TimerThread.run(Timer.java:516)

```

I'm working on it and I'll be back soon with news.

> SimpleLanguage cache issue
> --------------------------
>
>                 Key: CAMEL-19014
>                 URL: https://issues.apache.org/jira/browse/CAMEL-19014
>             Project: Camel
>          Issue Type: Bug
>    Affects Versions: 3.19.0, 3.20.1, 3.20.2
>            Reporter: Andrea Evangelista
>            Assignee: Rhuan Rocha
>            Priority: Major
>
> Hi guys, I'm attaching a test class that will reproduce the issue that I'm 
> experiencing.
> As summary: The cache inside the SimpleLanguage class looks like it's going 
> to be affected by the evaluation of the simple expression, producing 
> unexpected results.
> When the method *resolveTemplate* is used the result is not the expected one.
> To make it work I have to simulate a new entry in the cache making use of the 
> method *resolveTemplateNoCache.*
> Thanks in advance
> {code:java}
> public class SimpleLanguageTest extends CamelTestSupport {
>     @EndpointInject("mock:result")
>     private MockEndpoint mockResult;
>     @EndpointInject("mock:fail")
>     private MockEndpoint mockWithFailure;
>     @Test
>     public void whenSimpleLanguageNotUseCachedEntriesItWillNotFail() throws 
> Exception {
>         mockResult.await(20, TimeUnit.SECONDS);
>         mockResult.expectedMessageCount(102);
>         assertMockEndpointsSatisfied();
>         List<Exchange> exchanges = mockResult.getExchanges();
>         exchanges.stream()
>                 .forEach(exchange -> 
> assertTrue(exchange.getMessage().getHeader("#CustomHeader", 
> String.class).equals("This is a test a with startLabel: `Document` endLabel: 
> `Document` and label: `ALabel`")));
>     }
>     @Test
>     public void whenSimpleLanguageUseCachedEntriesItWillFail() throws 
> Exception {
>         mockWithFailure.expectedMessageCount(102);
>         assertMockEndpointsSatisfied();
>         List<Exchange> exchanges = mockWithFailure.getExchanges();
>         exchanges.stream()
>                 .forEach(exchange -> 
> assertTrue(exchange.getMessage().getHeader("#CustomHeader", 
> String.class).equals("This is a test a with startLabel: `Document` endLabel: 
> `Document` and label: `ALabel`")));
>     }
>     @Override
>     protected RoutesBuilder createRouteBuilder() throws Exception {
>         return new RouteBuilder() {
>             Map body = new HashMap() {{
>                 put("label", "ALabel");
>                 put("startLabel", "Document");
>                 put("endLabel", "Document");
>             }};
>             String simpleTemplate = "This is a test a with startLabel: 
> `${body.get('startLabel')}` endLabel: `${body.get('endLabel')}` and label: 
> `${body.get('label')}`";
>             @Override
>             public void configure() throws Exception {
>                 from("timer://test-timer?fixedRate=true&period=10&delay=1")
>                         .process(new Processor() {
>                             @Override
>                             public void process(Exchange exchange) throws 
> Exception {
>                                 exchange.getMessage().setBody(body);
>                                 
> exchange.getMessage().setHeader("#CustomHeader", 
> resolveTemplateNoCache(simpleTemplate, exchange));
>                             }
>                         })
>                         .to("mock:result");
>                 from("timer://test-timer1?fixedRate=true&period=10&delay=1")
>                         .process(new Processor() {
>                             @Override
>                             public void process(Exchange exchange) throws 
> Exception {
>                                 exchange.getMessage().setBody(body);
>                                 
> exchange.getMessage().setHeader("#CustomHeader", 
> resolveTemplateNoCache(simpleTemplate, exchange));
>                             }
>                         })
>                         .to("mock:result");
>                 from("timer://test-timer2?fixedRate=true&period=10&delay=1")
>                         .process(new Processor() {
>                             @Override
>                             public void process(Exchange exchange) throws 
> Exception {
>                                 exchange.getMessage().setBody(body);
>                                 
> exchange.getMessage().setHeader("#CustomHeader", 
> resolveTemplateNoCache(simpleTemplate, exchange));
>                             }
>                         })
>                         .to("mock:result");
>                 from("timer://test-timer3?fixedRate=true&period=10&delay=1")
>                         .process(new Processor() {
>                             @Override
>                             public void process(Exchange exchange) throws 
> Exception {
>                                 exchange.getMessage().setBody(body);
>                                 
> exchange.getMessage().setHeader("#CustomHeader", 
> resolveTemplate(simpleTemplate, exchange));
>                             }
>                         })
>                         .to("mock:fail");
>                 from("timer://test-timer4?fixedRate=true&period=10&delay=1")
>                         .process(new Processor() {
>                             @Override
>                             public void process(Exchange exchange) throws 
> Exception {
>                                 exchange.getMessage().setBody(body);
>                                 
> exchange.getMessage().setHeader("#CustomHeader", 
> resolveTemplate(simpleTemplate, exchange));
>                             }
>                         })
>                         .to("mock:fail");
>                 from("timer://test-timer5?fixedRate=true&period=10&delay=1")
>                         .process(new Processor() {
>                             @Override
>                             public void process(Exchange exchange) throws 
> Exception {
>                                 exchange.getMessage().setBody(body);
>                                 
> exchange.getMessage().setHeader("#CustomHeader", 
> resolveTemplate(simpleTemplate, exchange));
>                             }
>                         })
>                         .to("mock:fail");
>             }
>         };
>     }
>     public String resolveTemplate(String template, Exchange exchange) {
>         var simpleExpression = new SimpleExpression();
>         simpleExpression.setExpression(template);
>         return simpleExpression.evaluate(exchange, String.class);
>     }
>     public String resolveTemplateNoCache(String template, Exchange exchange) {
>         var simpleExpression = new SimpleExpression();
>         //This will force to create a new entry in the cache in the 
> SimpleLanguage class
>         String nocache = String.join("-", "-nocache", 
> UUID.randomUUID().toString());
>         simpleExpression.setExpression("%s%s".formatted(template, nocache));
>         return simpleExpression.evaluate(exchange, 
> String.class).replace(nocache, "");
>     }
> }
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to