Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/940#discussion_r118194366
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
---
@@ -146,9 +146,17 @@ private BitSet
setFilterdIndexToBitSet(FixedLengthDimensionDataChunk dimColumnDa
BitSet bitSet = new BitSet(numerOfRows);
bitSet.flip(0, numerOfRows);
byte[][] filterValues = dimColumnExecuterInfo.getFilterKeys();
- for (int k = 0; k < filterValues.length; k++) {
+ if (filterValues.length > 1) {
--- End diff --
This code will not work when No Inverted index is configured for that
column while creating the column. In that case data wont be sorted and this
code will five wrong result and whether filter value is one or more than one
this if data is sorted we can add binary search
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
