GitHub user mayunSaicmotor opened a pull request: https://github.com/apache/carbondata/pull/980
[CARBONDATA-1110] put if clause out of the for clause it is better to put if clause out of the for clause in FilterScanner.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/mayunSaicmotor/incubator-carbondata CARBONDATA-1110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/980.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #980 ---- commit d050de9f9acfdaebf3353cfc3a94e2f8b3381c04 Author: mayun <simafengyun1...@163.com> Date: 2017-05-24T06:04:43Z use binarySearch to replace for clause to improve performance commit eea2f039772de8340660c0b142241d79635eeb8e Author: mayun <simafengyun1...@163.com> Date: 2017-05-26T10:13:25Z add comments commit 0f281f0f5e28953cc87a9f74cd39072aca20137d Author: mayun <simafengyun1...@163.com> Date: 2017-05-26T14:46:18Z remove comment commit b632d9d4067e243c821d98f2497c61cff3160316 Author: mayun <simafengyun1...@163.com> Date: 2017-05-27T05:18:59Z Revert "fix issue of rebase" This reverts commit bf44c9f6ee4b059c384703ab12aebea4f4fed5e2. commit a8f0e0a03a7027da86666021c2f409e3729849a7 Author: mayun <simafengyun1...@163.com> Date: 2017-05-27T05:19:31Z Revert "Revert "fix issue of rebase"" This reverts commit b632d9d4067e243c821d98f2497c61cff3160316. commit e3be8c0ef8725a4e185f15261d4c8caca3c95601 Author: mayun <simafengyun1...@163.com> Date: 2017-05-29T12:35:11Z add comment commit 19fd3e62677c84e78cdd4f74c467c22f0110a0c9 Author: mayun <simafengyun1...@163.com> Date: 2017-05-29T15:42:30Z change 120000 to 32000 commit c2cf74b16ec89a80b6924e455b728c3498c1d9e1 Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:09:04Z put if clause out of for clause commit 9125358b32231d80f7dc85997f47e3fa5e68a595 Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:13:01Z Revert "put if clause out of for clause" This reverts commit c2cf74b16ec89a80b6924e455b728c3498c1d9e1. commit 497c8de1be16d72375e6b6af81b099ef35c092fb Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:16:35Z put if clause out of for clause commit d3758d80a6856295f1aec61150fc6ac9ae1b9b98 Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:18:35Z Revert "put if clause out of for clause" This reverts commit 497c8de1be16d72375e6b6af81b099ef35c092fb. commit fdabd55bfbc8e53ac995c06299adb3e0f729e0d0 Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:18:36Z Revert "Revert "put if clause out of for clause"" This reverts commit 9125358b32231d80f7dc85997f47e3fa5e68a595. commit e79dd4035d1c3419a801e22449b4e659c9169bef Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:18:36Z Revert "put if clause out of for clause" This reverts commit c2cf74b16ec89a80b6924e455b728c3498c1d9e1. commit 766c69a46c84ddf16acc1a00b11798ab144e2d87 Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:18:36Z Revert "change 120000 to 32000" This reverts commit 19fd3e62677c84e78cdd4f74c467c22f0110a0c9. commit f9eab12eb381d83196154c50784b705a655b0088 Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:18:36Z Revert "add comment" This reverts commit e3be8c0ef8725a4e185f15261d4c8caca3c95601. commit 605c449648fd1da6c9650aaa434fc22b09a4b2bf Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:18:37Z Revert "Revert "Revert "fix issue of rebase""" This reverts commit a8f0e0a03a7027da86666021c2f409e3729849a7. commit ecbb8bd2b3161dc578b05a74cfb230610089a114 Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:18:37Z Revert "Revert "fix issue of rebase"" This reverts commit b632d9d4067e243c821d98f2497c61cff3160316. commit 545577bde569dd2cfdbeedf9e254280b8252227f Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:18:37Z Revert "remove comment" This reverts commit 0f281f0f5e28953cc87a9f74cd39072aca20137d. commit 34b90c9d7b50b087f6b65a9f9886292769ca57ef Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:18:38Z Revert "add comments" This reverts commit eea2f039772de8340660c0b142241d79635eeb8e. commit 11e5aaeae5a7340186269d6a6e58b9d5aab100d6 Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:18:38Z Revert "use binarySearch to replace for clause to improve performance" This reverts commit d050de9f9acfdaebf3353cfc3a94e2f8b3381c04. commit d5c4ed5a8633cdec29834442cf83bf46c8a3e853 Author: mayun <simafengyun1...@163.com> Date: 2017-05-31T10:20:45Z put if clause out of for clause ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---