Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/971#discussion_r119895320
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/measure/v3/CompressedMeasureChunkFileBasedReaderV3.java
---
@@ -220,13 +223,25 @@ public
CompressedMeasureChunkFileBasedReaderV3(BlockletInfo blockletInfo, String
valueEncodeMeta.add(CarbonUtil
.deserializeEncoderMetaNew(measureColumnChunk.getEncoder_meta().get(i).array()));
}
- WriterCompressModel compressionModel =
CarbonUtil.getValueCompressionModel(valueEncodeMeta);
- ValueCompressionHolder values =
compressionModel.getValueCompressionHolder()[0];
+
+ MeasurePageStatistics stats =
CarbonUtil.getMeasurePageStats(valueEncodeMeta);
--- End diff --
This code is repeated in CompressedMeasureChunkFileBasedReaderV2 and
CompressedMeasureChunkFileBasedReaderV3, if we move it to a shared function, a
result object need to be created, since multiple results are needed (stats,
convertedType, values).
Actually in #987 , usage of `CompressionFinder` is removed in write path, I
think another PR is needed to remove it for read path also, after this is done,
`CompressionFinder` related class and the whole
`org.apache.carbondata.core.datastore.compression` package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
