Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1020#discussion_r121382483
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala
---
@@ -37,6 +37,12 @@ class TestSortColumns extends QueryTest with
BeforeAndAfterAll {
checkAnswer(sql("select empno from sorttable1"), sql("select empno
from sorttable1 order by empno"))
}
+ test("create table with no dictionary sort_columns with dictionary
exclude") {
--- End diff --
Suggest to add test case for:
NumberOfNoDictSortColumns < NoDictionaryCount
It means some no dictionary columns are in sort_columns and some no
dictioanry columns are not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
